-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[lld] Add infrastructure for handling RISCV vendor-specific relocations. #159987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
resistor
wants to merge
6
commits into
llvm:main
Choose a base branch
from
resistor:lld-vendor-reloc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a98c677
[lld] Add infrastructure for handling RISCV vendor-specific relocations.
resistor 046b6cc
Switch to using getVendorRelExpr to avoid adding a new argument to ge…
resistor d259005
Remove remnant of an earlier attempt that was accidentally included.
resistor 3626594
Update for review comments.
resistor d27799a
Update for review feedback.
resistor f8664fd
Use a fake vendor relocation in the testcase.
resistor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# RUN: llvm-mc -triple riscv32 %s -filetype=obj -o %t.o | ||
# RUN: not ld.lld -pie %t.o -o /dev/null 2>&1 | FileCheck %s | ||
|
||
.option exact | ||
|
||
.global TARGET | ||
TARGET: | ||
nop | ||
|
||
.global INVALID_VENDOR | ||
.reloc 1f, R_RISCV_VENDOR, INVALID_VENDOR+0 | ||
.reloc 1f, R_RISCV_CUSTOM255, TARGET | ||
1: | ||
nop | ||
|
||
# CHECK: error: {{.*}} unknown vendor-specific relocation (255) in vendor namespace "INVALID_VENDOR" against symbol TARGET |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the PR is useful. It adds some stuff that is not testable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every new line, except the error path for non-RV targets, is executed when running the included test, and the correctness of the parsing is verified by checking the vendor name in the error message.