Skip to content

[TEST][WIP] Run clang-tidy inside ci-container #160193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[TEST][WIP] Run clang-tidy inside ci-container #160193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b0881
add clang-tidy violations
vbvictor Oct 20, 2025
732b4ca
test linter
vbvictor Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions .github/workflows/pr-code-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run:
shell: bash
container:
image: 'ghcr.io/llvm/ci-ubuntu-24.04:latest'
image: 'ghcr.io/llvm/ci-ubuntu-24.04-lint'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -31,6 +31,11 @@ jobs:
with:
fetch-depth: 2

# FIXME: same as in ".github/workflows/pr-code-format.yml"
- name: Set Safe Directory
run: |
chown -R root $(pwd)

- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c # v46.0.5
Expand All @@ -46,22 +51,6 @@ jobs:
run: |
echo "Changed files:"
echo "$CHANGED_FILES"

# The clang tidy version should always be upgraded to the first version
# of a release cycle (x.1.0) or the last version of a release cycle, or
# if there have been relevant clang-format backports.
- name: Install clang-tidy
uses: aminya/setup-cpp@a276e6e3d1db9160db5edc458e99a30d3b109949 # v1.7.1
with:
clang-tidy: 21.1.0

- name: Setup Python env
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: '3.13'

- name: Install Python dependencies
run: python3 -m pip install -r llvm/utils/git/requirements_linting.txt

# TODO: create special mapping for 'codegen' targets, for now build predefined set
# TODO: add entrypoint in 'compute_projects.py' that only adds a project and its direct dependencies
Expand Down
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/ClangTidy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace clang::tidy {

#if CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS
namespace custom {
void (*RegisterCustomChecks)(const ClangTidyOptions &O,
void (*RegisterCustomChecks)(const ClangTidyOptions &o,
ClangTidyCheckFactories &Factories) = nullptr;
} // namespace custom
#endif
Expand Down
6 changes: 3 additions & 3 deletions clang-tools-extra/clangd/tool/ClangdMain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,11 +995,11 @@ clangd accepts flags on the commandline, and in the CLANGD_FLAGS environment var
Opts.PreambleParseForwardingFunctions = PreambleParseForwardingFunctions;
Opts.ImportInsertions = ImportInsertions;
Opts.QueryDriverGlobs = std::move(QueryDriverGlobs);
Opts.TweakFilter = [&](const Tweak &T) {
if (T.hidden() && !HiddenFeatures)
Opts.TweakFilter = [&](const Tweak &t) {
if (t.hidden() && !HiddenFeatures)
return false;
if (TweakList.getNumOccurrences())
return llvm::is_contained(TweakList, T.id());
return llvm::is_contained(TweakList, t.id());
return true;
};
if (ForceOffsetEncoding != OffsetEncoding::UnsupportedEncoding)
Expand Down
Loading