Skip to content

[lldb] Fix TypeSystemClang::GetBasicTypeEnumeration for 128-bit int types #162278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 13, 2025
Merged

[lldb] Fix TypeSystemClang::GetBasicTypeEnumeration for 128-bit int types #162278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04fea01
[lldb] Fix the TypeSystemClang::GetBasicTypeEnumeration wrt. 128-bit …
Oct 7, 2025
7092c65
[lldb] reverting some of the previous changes that break backward-com…
Oct 9, 2025
89f0306
[lldb] reverting some of the previous changes that break backward-com…
Oct 9, 2025
02885e1
[lldb] add comments concerning the 128-bit integer types
Oct 10, 2025
46d5e22
[lldb] add a new API test that checks the size of the chosen basic types
Oct 12, 2025
def1853
[lldb] joining the the two tests (back) into a single test
Oct 13, 2025
bd140fb
[lldb] adding a comment above the lines that were added previously to…
Oct 13, 2025
18ddeec
[lldb] test also the sizes of the chosen aliases of basic types
Oct 13, 2025
736539e
[lldb] inlining "setUp" (back) to the "test" method
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,8 +849,8 @@ lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name) {
{"unsigned long long int", eBasicTypeUnsignedLongLong},

// "int128"
{"__int128_t", eBasicTypeInt128},
{"__uint128_t", eBasicTypeUnsignedInt128},
{"__int128", eBasicTypeInt128},
{"unsigned __int128", eBasicTypeUnsignedInt128},

Comment on lines 851 to 866
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave in the old defines in to make sure it doesn't break anyone? So just add the new entries and leave the old ones?

// "bool"
{"bool", eBasicTypeBool},
Expand Down
4 changes: 2 additions & 2 deletions lldb/unittests/Symbol/TestTypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ TEST_F(TestTypeSystemClang, TestGetBasicTypeFromName) {
GetBasicQualType("unsigned long long"));
EXPECT_EQ(GetBasicQualType(eBasicTypeUnsignedLongLong),
GetBasicQualType("unsigned long long int"));
EXPECT_EQ(GetBasicQualType(eBasicTypeInt128), GetBasicQualType("__int128_t"));
EXPECT_EQ(GetBasicQualType(eBasicTypeInt128), GetBasicQualType("__int128"));
EXPECT_EQ(GetBasicQualType(eBasicTypeUnsignedInt128),
GetBasicQualType("__uint128_t"));
GetBasicQualType("unsigned __int128"));
Comment on lines 162 to 167
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave old mappings in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit that these tests back.

EXPECT_EQ(GetBasicQualType(eBasicTypeVoid), GetBasicQualType("void"));
EXPECT_EQ(GetBasicQualType(eBasicTypeBool), GetBasicQualType("bool"));
EXPECT_EQ(GetBasicQualType(eBasicTypeFloat), GetBasicQualType("float"));
Expand Down
Loading