Skip to content

[libcxx] Remove Redundant Reset in ~basic_string #164718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
+6 −1
Merged

[libcxx] Remove Redundant Reset in ~basic_string #164718

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a97f2d
[libcxx] Remove Redundant Reset in ~basic_string
boomanaiden154 Oct 22, 2025
9de412d
refactor
boomanaiden154 Oct 23, 2025
a98ac47
feedback
boomanaiden154 Nov 3, 2025
fa510f2
Add TODO
boomanaiden154 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libcxx/include/string
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ basic_string<char32_t> operator""s( const char32_t *str, size_t len );
# include <__utility/forward.h>
# include <__utility/is_pointer_in_range.h>
# include <__utility/move.h>
# include <__utility/no_destroy.h>
# include <__utility/scope_guard.h>
# include <__utility/swap.h>
# include <climits>
Expand Down Expand Up @@ -918,6 +919,7 @@ private:
__rep() = default;
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 __rep(__short __r) : __s(__r) {}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 __rep(__long __r) : __l(__r) {}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 __rep(__uninitialized_tag) {}
};

_LIBCPP_COMPRESSED_PAIR(__rep, __rep_, allocator_type, __alloc_);
Expand Down Expand Up @@ -1210,7 +1212,10 @@ public:
}
# endif // _LIBCPP_CXX03_LANG

inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() { __reset_internal_buffer(); }
// TODO(boomanaiden154): Once we mark this in destructors as dead on return,
// we can use a normal call to __reset_internal_buffer and remove the extra
// __rep constructor.
inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() { __reset_internal_buffer(__rep(__uninitialized_tag())); }

_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 operator __self_view() const _NOEXCEPT {
return __self_view(typename __self_view::__assume_valid(), data(), size());
Expand Down
Loading