Skip to content

[lldb][TypeSystem] Fix GetTypeInfo for vector and complex types #165837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

[lldb][TypeSystem] Fix GetTypeInfo for vector and complex types #165837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28998bb
[lldb][TypeSystem] Fix GetTypeInfo for vector and complex types
Michael137 Oct 31, 2025
31624a9
fixup! check other typeinfo bits too
Michael137 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3965,9 +3965,9 @@ TypeSystemClang::GetTypeInfo(lldb::opaque_compiler_type_t type,
if (complex_type) {
clang::QualType complex_element_type(complex_type->getElementType());
if (complex_element_type->isIntegerType())
complex_type_flags |= eTypeIsFloat;
else if (complex_element_type->isFloatingType())
complex_type_flags |= eTypeIsInteger;
else if (complex_element_type->isFloatingType())
complex_type_flags |= eTypeIsFloat;
}
return complex_type_flags;
} break;
Expand Down Expand Up @@ -4062,12 +4062,17 @@ TypeSystemClang::GetTypeInfo(lldb::opaque_compiler_type_t type,
uint32_t vector_type_flags = eTypeHasChildren | eTypeIsVector;
const clang::VectorType *vector_type = llvm::dyn_cast<clang::VectorType>(
qual_type->getCanonicalTypeInternal());
if (vector_type) {
if (vector_type->isIntegerType())
vector_type_flags |= eTypeIsFloat;
else if (vector_type->isFloatingType())
vector_type_flags |= eTypeIsInteger;
}
if (!vector_type)
return 0;

QualType element_type = vector_type->getElementType();
if (element_type.isNull())
return 0;

if (element_type->isIntegerType())
vector_type_flags |= eTypeIsInteger;
else if (element_type->isFloatingType())
vector_type_flags |= eTypeIsFloat;
return vector_type_flags;
}
default:
Expand Down
24 changes: 24 additions & 0 deletions lldb/unittests/Symbol/TestTypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,30 @@ TEST_F(TestTypeSystemClang, AddMethodToCXXRecordType_ParmVarDecls) {
EXPECT_EQ(method_it->getParamDecl(1)->getDeclContext(), *method_it);
}

TEST_F(TestTypeSystemClang, TestGetTypeInfo) {
// Tests TypeSystemClang::GetTypeInfo

const ASTContext &ast = m_ast->getASTContext();

CompilerType complex_int = m_ast->GetType(ast.getComplexType(ast.IntTy));
EXPECT_EQ(complex_int.GetTypeInfo(),
(eTypeIsInteger | eTypeIsComplex | eTypeIsBuiltIn | eTypeHasValue));

CompilerType complex_float = m_ast->GetType(ast.getComplexType(ast.FloatTy));
EXPECT_EQ(complex_float.GetTypeInfo(),
(eTypeIsFloat | eTypeIsComplex | eTypeIsBuiltIn | eTypeHasValue));

CompilerType vector_of_int =
m_ast->GetType(ast.getVectorType(ast.IntTy, 1, VectorKind::Generic));
EXPECT_EQ(vector_of_int.GetTypeInfo(),
(eTypeIsInteger | eTypeIsVector | eTypeHasChildren));

CompilerType vector_of_float =
m_ast->GetType(ast.getVectorType(ast.FloatTy, 1, VectorKind::Generic));
EXPECT_EQ(vector_of_float.GetTypeInfo(),
(eTypeIsFloat | eTypeIsVector | eTypeHasChildren));
}

TEST_F(TestTypeSystemClang, AsmLabel_CtorDtor) {
// Tests TypeSystemClang::DeclGetMangledName for constructors/destructors
// with and without AsmLabels.
Expand Down
Loading