Skip to content

Conversation

@mstorsjo
Copy link
Member

@mstorsjo mstorsjo commented Nov 4, 2025

Since 022e782 (2017) this attribute has an effect on both aarch64 and x86_64; update the docs to reflect this.

Since 022e782 (2017) this attribute
has an effect on both aarch64 and x86_64; update the docs to reflect
this.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Nov 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 4, 2025

@llvm/pr-subscribers-clang

Author: Martin Storsjö (mstorsjo)

Changes

Since 022e782 (2017) this attribute has an effect on both aarch64 and x86_64; update the docs to reflect this.


Full diff: https://github.com/llvm/llvm-project/pull/166373.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/AttrDocs.td (+3-3)
diff --git a/clang/include/clang/Basic/AttrDocs.td b/clang/include/clang/Basic/AttrDocs.td
index 2fdd041c1b46e..1be9a96aa44de 100644
--- a/clang/include/clang/Basic/AttrDocs.td
+++ b/clang/include/clang/Basic/AttrDocs.td
@@ -3450,9 +3450,9 @@ Mac, and BSD. This attribute has no effect on other targets.
 def MSABIDocs : Documentation {
   let Category = DocCatCallingConvs;
   let Content = [{
-On non-Windows x86_64 targets, this attribute changes the calling convention of
-a function to match the default convention used on Windows x86_64. This
-attribute has no effect on Windows targets or non-x86_64 targets.
+On non-Windows x86_64 and aarch64 targets, this attribute changes the calling convention of
+a function to match the default convention used on Windows. This
+attribute has no effect on Windows targets or non-x86_64, non-aarch64 targets.
   }];
 }
 

@mstorsjo mstorsjo merged commit d4e3a23 into llvm:main Nov 5, 2025
14 checks passed
@mstorsjo mstorsjo deleted the clang-doc-ms-abi branch November 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants