Skip to content

Conversation

@rupprecht
Copy link
Collaborator

@rupprecht rupprecht commented Nov 4, 2025

Omitting -o /dev/null may try to write output to the current dir, which may not have write permissions on some build systems.

This fixes the test added by #165737

@rupprecht rupprecht added the skip-precommit-approval PR for CI feedback, not intended for review label Nov 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 4, 2025

@llvm/pr-subscribers-backend-nvptx

Author: Jordan Rupprecht (rupprecht)

Changes

Omitting -o /dev/null may try to write output to the current dir, which may not have write permissions on some build systems.


Full diff: https://github.com/llvm/llvm-project/pull/166404.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/NVPTX/cmpxchg-unsupported-syncscope.err.ll (+1-1)
diff --git a/llvm/test/CodeGen/NVPTX/cmpxchg-unsupported-syncscope.err.ll b/llvm/test/CodeGen/NVPTX/cmpxchg-unsupported-syncscope.err.ll
index d3853e2fdaa88..4d81fdc67736d 100644
--- a/llvm/test/CodeGen/NVPTX/cmpxchg-unsupported-syncscope.err.ll
+++ b/llvm/test/CodeGen/NVPTX/cmpxchg-unsupported-syncscope.err.ll
@@ -1,4 +1,4 @@
-; RUN: not llc -mcpu=sm_100a -mtriple=nvptx64 -mattr=+ptx86 %s 2>&1 | FileCheck %s
+; RUN: not llc -mcpu=sm_100a -mtriple=nvptx64 -mattr=+ptx86 %s -o /dev/null 2>&1 | FileCheck %s
 
 ; Test that we get a clear error message when using an unsupported syncscope.
 

@rupprecht rupprecht enabled auto-merge (squash) November 4, 2025 17:09
@durga4github durga4github requested a review from smada3 November 4, 2025 17:09
@durga4github durga4github changed the title [test] Avoid writing test output to readonly dir [NVPTX][Tests] Avoid writing test output to readonly dir Nov 4, 2025
@smada3
Copy link
Contributor

smada3 commented Nov 4, 2025

LGTM

@rupprecht rupprecht merged commit 8aff0d9 into llvm:main Nov 4, 2025
10 of 12 checks passed
@rupprecht rupprecht deleted the nvptx-test-output-dir branch November 4, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:NVPTX skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants