[OpenMP] Add libomp unit test infrastructure #168063
Open
+475
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-i
force-pushed
the
users/ro-i/check-libomp-unit
branch
from
4c9e176 to
c801cb4
Compare
shiltian
reviewed
Nov 14, 2025
ro-i
commented
Nov 18, 2025
shiltian
reviewed
Nov 18, 2025
Meinersbur
reviewed
Dec 2, 2025
ro-i
force-pushed
the
users/ro-i/check-libomp-unit
branch
from
2f30670 to
b12ff59
Compare
shiltian
reviewed
Dec 17, 2025
| set_target_properties(OpenMPUnitTests PROPERTIES FOLDER "OpenMP/Tests") | ||
|
|
||
| if(WIN32 OR STUBS_LIBRARY) | ||
| message(WARNING "OpenMP unittests disabled due to stub library or Windows") |
Contributor
There was a problem hiding this comment.
Any reason this doesn't work on Windows?
Contributor
Author
There was a problem hiding this comment.
I don't think so. But since the CMake changes are already complicated enough to review and test as they are, I thought it might be best to get things working first and then add something like the Windows support in a follow-up
Co-authored-by: Shilei Tian <i@tianshilei.me>
jplehr
reviewed
Dec 17, 2025
Contributor
jplehr
left a comment
jplehr
left a comment
There was a problem hiding this comment.
+1 for adding unit tests here!
Meinersbur
reviewed
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The tests in
TestKmpStr.cppare an automatically generated POC to make sure things work.)