[NVVM] Move print functions from NVVMIntrinsicUtils.h to cpp file #168997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the print functions from NVVMIntrinsicUtils.h to NVVMIntrinsicUtils.cpp, a file created in the llvm/lib/IR directory. Signed-off-by: Dharuni R Acharya <dharunira@nvidia.com>
Member
|
@llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-nvptx Author: Dharuni R Acharya (DharuniRAcharya) ChangesThis patch moves the print functions from Full diff: https://github.com/llvm/llvm-project/pull/168997.diff 3 Files Affected:
diff --git a/llvm/include/llvm/IR/NVVMIntrinsicUtils.h b/llvm/include/llvm/IR/NVVMIntrinsicUtils.h
index d383769043605..a6356a99b9c77 100644
--- a/llvm/include/llvm/IR/NVVMIntrinsicUtils.h
+++ b/llvm/include/llvm/IR/NVVMIntrinsicUtils.h
@@ -662,50 +662,9 @@ inline APFloat::roundingMode GetFMARoundingMode(Intrinsic::ID IntrinsicID) {
llvm_unreachable("Invalid FP instrinsic rounding mode for NVVM fma");
}
-inline void printTcgen05MMAKind(raw_ostream &OS, const Constant *ImmArgVal) {
- if (const auto *CI = dyn_cast<ConstantInt>(ImmArgVal)) {
- uint64_t Val = CI->getZExtValue();
- switch (static_cast<Tcgen05MMAKind>(Val)) {
- case Tcgen05MMAKind::F16:
- OS << "f16";
- return;
- case Tcgen05MMAKind::TF32:
- OS << "tf32";
- return;
- case Tcgen05MMAKind::F8F6F4:
- OS << "f8f6f4";
- return;
- case Tcgen05MMAKind::I8:
- OS << "i8";
- return;
- }
- }
- llvm_unreachable(
- "printTcgen05MMAKind called with invalid value for immediate argument");
-}
+void printTcgen05MMAKind(raw_ostream &OS, const Constant *ImmArgVal);
-inline void printTcgen05CollectorUsageOp(raw_ostream &OS,
- const Constant *ImmArgVal) {
- if (const auto *CI = dyn_cast<ConstantInt>(ImmArgVal)) {
- uint64_t Val = CI->getZExtValue();
- switch (static_cast<Tcgen05CollectorUsageOp>(Val)) {
- case Tcgen05CollectorUsageOp::DISCARD:
- OS << "discard";
- return;
- case Tcgen05CollectorUsageOp::LASTUSE:
- OS << "lastuse";
- return;
- case Tcgen05CollectorUsageOp::FILL:
- OS << "fill";
- return;
- case Tcgen05CollectorUsageOp::USE:
- OS << "use";
- return;
- }
- }
- llvm_unreachable("printTcgen05CollectorUsageOp called with invalid value for "
- "immediate argument");
-}
+void printTcgen05CollectorUsageOp(raw_ostream &OS, const Constant *ImmArgVal);
} // namespace nvvm
} // namespace llvm
diff --git a/llvm/lib/IR/CMakeLists.txt b/llvm/lib/IR/CMakeLists.txt
index 10572ff708bd3..31821a2d6b208 100644
--- a/llvm/lib/IR/CMakeLists.txt
+++ b/llvm/lib/IR/CMakeLists.txt
@@ -35,6 +35,7 @@ add_llvm_component_library(LLVMCore
GVMaterializer.cpp
Globals.cpp
Intrinsics.cpp
+ NVVMIntrinsicUtils.cpp
IRBuilder.cpp
IRPrintingPasses.cpp
SSAContext.cpp
diff --git a/llvm/lib/IR/NVVMIntrinsicUtils.cpp b/llvm/lib/IR/NVVMIntrinsicUtils.cpp
new file mode 100644
index 0000000000000..bf5c25c891cea
--- /dev/null
+++ b/llvm/lib/IR/NVVMIntrinsicUtils.cpp
@@ -0,0 +1,61 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file implements functions associated with NVVM Intrinsics.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/IR/NVVMIntrinsicUtils.h"
+
+using namespace llvm;
+using namespace nvvm;
+
+void nvvm::printTcgen05MMAKind(raw_ostream &OS, const Constant *ImmArgVal) {
+ if (const auto *CI = dyn_cast<ConstantInt>(ImmArgVal)) {
+ uint64_t Val = CI->getZExtValue();
+ switch (static_cast<Tcgen05MMAKind>(Val)) {
+ case Tcgen05MMAKind::F16:
+ OS << "f16";
+ return;
+ case Tcgen05MMAKind::TF32:
+ OS << "tf32";
+ return;
+ case Tcgen05MMAKind::F8F6F4:
+ OS << "f8f6f4";
+ return;
+ case Tcgen05MMAKind::I8:
+ OS << "i8";
+ return;
+ }
+ }
+ llvm_unreachable(
+ "printTcgen05MMAKind called with invalid value for immediate argument");
+}
+
+void nvvm::printTcgen05CollectorUsageOp(raw_ostream &OS,
+ const Constant *ImmArgVal) {
+ if (const auto *CI = dyn_cast<ConstantInt>(ImmArgVal)) {
+ uint64_t Val = CI->getZExtValue();
+ switch (static_cast<Tcgen05CollectorUsageOp>(Val)) {
+ case Tcgen05CollectorUsageOp::DISCARD:
+ OS << "discard";
+ return;
+ case Tcgen05CollectorUsageOp::LASTUSE:
+ OS << "lastuse";
+ return;
+ case Tcgen05CollectorUsageOp::FILL:
+ OS << "fill";
+ return;
+ case Tcgen05CollectorUsageOp::USE:
+ OS << "use";
+ return;
+ }
+ }
+ llvm_unreachable("printTcgen05CollectorUsageOp called with invalid value for "
+ "immediate argument");
+}
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
🐧 Linux x64 Test Results
|
durga4github
approved these changes
Nov 21, 2025
Contributor
durga4github
left a comment
durga4github
left a comment
There was a problem hiding this comment.
Let us wait for @jurahul to have a look
jurahul
approved these changes
Nov 21, 2025
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
…ile (llvm#168997) This patch moves the print functions from `NVVMIntrinsicUtils.h` to `NVVMIntrinsicUtils.cpp`, a file created in the `llvm/lib/IR` directory. Signed-off-by: Dharuni R Acharya <dharunira@nvidia.com>
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13467 Here is the relevant piece of the build log for the reference |
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
…ile (llvm#168997) This patch moves the print functions from `NVVMIntrinsicUtils.h` to `NVVMIntrinsicUtils.cpp`, a file created in the `llvm/lib/IR` directory. Signed-off-by: Dharuni R Acharya <dharunira@nvidia.com>
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
…ile (llvm#168997) This patch moves the print functions from `NVVMIntrinsicUtils.h` to `NVVMIntrinsicUtils.cpp`, a file created in the `llvm/lib/IR` directory. Signed-off-by: Dharuni R Acharya <dharunira@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the print functions from
NVVMIntrinsicUtils.htoNVVMIntrinsicUtils.cpp, a file created in thellvm/lib/IRdirectory.