Skip to content

[mlir][bazel] Build MLIR bindings extensions with nanobind_bazel #169306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicholasjng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[mlir][bazel] Build MLIR bindings extensions with nanobind_bazel #169306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions utils/bazel/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module(name = "llvm-project-overlay")

bazel_dep(name = "apple_support", version = "1.24.1", repo_name = "build_bazel_apple_support")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
bazel_dep(name = "nanobind_bazel", version = "2.9.2")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "protobuf", version = "31.1", repo_name = "com_google_protobuf")
bazel_dep(name = "rules_android", version = "0.6.6")
Expand All @@ -25,11 +26,9 @@ use_repo(
"llvm_zstd",
"mpc",
"mpfr",
"nanobind",
"pfm",
"pybind11",
"pyyaml",
"robin_map",
"vulkan_headers",
"vulkan_sdk",
)
Expand Down
17 changes: 0 additions & 17 deletions utils/bazel/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,23 +105,6 @@ def _llvm_repos_extension_impl(module_ctx):
build_file = "@llvm-raw//utils/bazel/third_party_build:pyyaml.BUILD",
)

# TODO: bump to robin-map-1.4.0
http_archive(
name = "robin_map",
build_file = "@llvm-raw//utils/bazel/third_party_build:robin_map.BUILD",
sha256 = "a8424ad3b0affd4c57ed26f0f3d8a29604f0e1f2ef2089f497f614b1c94c7236",
strip_prefix = "robin-map-1.3.0",
url = "https://github.com/Tessil/robin-map/archive/refs/tags/v1.3.0.tar.gz",
)

http_archive(
name = "nanobind",
build_file = "@llvm-raw//utils/bazel/third_party_build:nanobind.BUILD",
sha256 = "8ce3667dce3e64fc06bfb9b778b6f48731482362fb89a43da156632266cd5a90",
strip_prefix = "nanobind-2.9.2",
url = "https://github.com/wjakob/nanobind/archive/refs/tags/v2.9.2.tar.gz",
)

llvm_repos_extension = module_extension(
implementation = _llvm_repos_extension_impl,
)
100 changes: 32 additions & 68 deletions utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
load("@nanobind_bazel//:build_defs.bzl", "nanobind_extension", "nanobind_library")
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
load("@rules_python//python:defs.bzl", "py_binary")
load("//llvm:targets.bzl", "llvm_targets")
Expand Down Expand Up @@ -1130,39 +1131,31 @@ cc_library(
],
)

cc_library(
nanobind_library(
name = "MLIRBindingsPythonNanobindHeaders",
includes = [
"include",
],
textual_hdrs = [":MLIRBindingsPythonHeaderFiles"],
deps = [
":CAPIIRHeaders",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)

cc_library(
nanobind_library(
name = "MLIRBindingsPythonNanobindHeadersAndDeps",
includes = [
"include",
],
textual_hdrs = [":MLIRBindingsPythonHeaderFiles"],
deps = [
":CAPIIR",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)

# These flags are needed for pybind11 to work.
PYBIND11_COPTS = [
"-fexceptions",
"-frtti",
]

PYBIND11_FEATURES = [
NB_FEATURES = [
# Cannot use header_modules (parse_headers feature fails).
"-use_header_modules",
]
Expand All @@ -1188,11 +1181,10 @@ filegroup(
]),
)

cc_library(
nanobind_library(
name = "MLIRBindingsPythonCore",
srcs = [":MLIRBindingsPythonSourceFiles"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
features = NB_FEATURES,
includes = [
"lib/Bindings/Python",
],
Expand All @@ -1207,16 +1199,14 @@ cc_library(
":Support",
":config",
"//llvm:Support",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)

cc_library(
nanobind_library(
name = "MLIRBindingsPythonCoreNoCAPI",
srcs = [":MLIRBindingsPythonSourceFiles"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
features = NB_FEATURES,
includes = [
"lib/Bindings/Python",
],
Expand All @@ -1230,7 +1220,6 @@ cc_library(
":Support",
":config",
"//llvm:Support",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)
Expand All @@ -1249,130 +1238,105 @@ cc_library(
)

# Dynamic library with the MLIR Python extension.
cc_binary(
name = "_mlir.so",
nanobind_extension(
name = "_mlir",
srcs = ["lib/Bindings/Python/MainModule.cpp"],
# These flags are needed for pybind11 to work.
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
features = NB_FEATURES,
includes = [
"lib/Bindings/Python",
],
linkshared = 1,
linkstatic = 0,
deps = [
":MLIRBindingsPythonCore",
":MLIRBindingsPythonHeadersAndDeps",
"@nanobind",
],
)

cc_binary(
name = "_mlirDialectsIRDL.so",
nanobind_extension(
name = "_mlirDialectsIRDL",
srcs = ["lib/Bindings/Python/DialectIRDL.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPIIR",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
],
)

cc_binary(
name = "_mlirDialectsLinalg.so",
nanobind_extension(
name = "_mlirDialectsLinalg",
srcs = ["lib/Bindings/Python/DialectLinalg.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
features = NB_FEATURES,
includes = [
"lib/Bindings/Python",
],
linkshared = 1,
linkstatic = 0,
deps = [
":CAPIIR",
":CAPILinalg",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
],
)

cc_binary(
name = "_mlirDialectsLLVM.so",
nanobind_extension(
name = "_mlirDialectsLLVM",
srcs = ["lib/Bindings/Python/DialectLLVM.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPIIR",
":CAPILLVM",
":CAPITarget",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
],
)

cc_binary(
name = "_mlirDialectsQuant.so",
nanobind_extension(
name = "_mlirDialectsQuant",
srcs = ["lib/Bindings/Python/DialectQuant.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPIIR",
":CAPIQuant",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
],
)

cc_binary(
name = "_mlirDialectsSparseTensor.so",
nanobind_extension(
name = "_mlirDialectsSparseTensor",
srcs = ["lib/Bindings/Python/DialectSparseTensor.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPIIR",
":CAPISparseTensor",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
],
)

# Dynamic library with the MLIR Conversions Python extension.
cc_binary(
name = "_mlirExecutionEngine.so",
nanobind_extension(
name = "_mlirExecutionEngine",
srcs = ["lib/Bindings/Python/ExecutionEngineModule.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPIExecutionEngine",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)

# Dynamic library with the MLIR Linalg dialect+passes Python extension.
cc_binary(
name = "_mlirLinalgPasses.so",
nanobind_extension(
name = "_mlirLinalgPasses",
srcs = ["lib/Bindings/Python/LinalgPasses.cpp"],
copts = PYBIND11_COPTS,
features = PYBIND11_FEATURES,
linkshared = 1,
features = NB_FEATURES,
linkstatic = 0,
deps = [
":CAPILinalg",
":MLIRBindingsPythonNanobindHeadersAndDeps",
"@nanobind",
"@rules_python//python/cc:current_py_cc_headers",
],
)
Expand Down
25 changes: 0 additions & 25 deletions utils/bazel/third_party_build/nanobind.BUILD
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions utils/bazel/third_party_build/robin_map.BUILD
View file
Open in desktop

This file was deleted.

Loading