[CIR][CIRGen][Builtin][X86] Multishift Intrinsics #169618
Open
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs25mtech12008
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Omkar Rasal (cs25mtech12008) ChangesAdded builtin support for the multishift operation with test file. changes has been done in CIRGenBuiltinX86 file Full diff: https://github.com/llvm/llvm-project/pull/169618.diff 2 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp b/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
index e7aa8a234efd9..4cbeecf0d8ea3 100644
--- a/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
@@ -877,9 +877,16 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
case X86::BI__builtin_ia32_vp2intersect_d_512:
case X86::BI__builtin_ia32_vp2intersect_d_256:
case X86::BI__builtin_ia32_vp2intersect_d_128:
+ cgm.errorNYI(expr->getSourceRange(),
+ std::string("unimplemented X86 builtin call: ") +
+ getContext().BuiltinInfo.getName(builtinID));
+ return {};
case X86::BI__builtin_ia32_vpmultishiftqb128:
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_128", ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpmultishiftqb256:
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_256", ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpmultishiftqb512:
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_512", ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpshufbitqmb128_mask:
case X86::BI__builtin_ia32_vpshufbitqmb256_mask:
case X86::BI__builtin_ia32_vpshufbitqmb512_mask:
diff --git a/clang/test/CIR/CodeGen/X86/builtin_multishift.c b/clang/test/CIR/CodeGen/X86/builtin_multishift.c
new file mode 100644
index 0000000000000..7c57ef3191d1d
--- /dev/null
+++ b/clang/test/CIR/CodeGen/X86/builtin_multishift.c
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi \
+// RUN: -fclangir -emit-cir %s -o - | FileCheck %s
+
+#include <immintrin.h>
+__m512i test_multishift(__m512i x, __m512i y) {
+ return _mm512_multishift_epi64_epi8(x, y);
+}
+
+// // CHECK: cir.func @test_multishift
+// // CHECK: cir.call @__builtin_ia32_vpmultishiftqb512
+
|
andykaylor
reviewed
Dec 1, 2025
Contributor
andykaylor
left a comment
andykaylor
left a comment
There was a problem hiding this comment.
Thanks for the patch! I have just a couple of requests for changes.
| getContext().BuiltinInfo.getName(builtinID)); | ||
| return {}; | ||
| case X86::BI__builtin_ia32_vpmultishiftqb128: | ||
| return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_128", ops[0].getType(), ops); |
Contributor
There was a problem hiding this comment.
Suggested change
| return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_128", ops[0].getType(), ops); | |
| return emitIntrinsicCallOp(builder, getLoc(expr->getExprLoc()), "x86_avx512_pmultishift_qb_128", ops[0].getType(), ops); |
You'll need to rebase your PR to get this new signature. It's been updated recently.
Comment on lines
+1
to
+2
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi \ | ||
| // RUN: -fclangir -emit-cir %s -o - | FileCheck %s |
Contributor
There was a problem hiding this comment.
Suggested change
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi \ | |
| // RUN: -fclangir -emit-cir %s -o - | FileCheck %s | |
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi -fclangir -emit-cir %s -o %t.cir | |
| // RUN: FileCheck --input-file=%t.cir --check-prefix=CIR %s | |
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi -fclangir -emit-llvm %s -o %t-cir.ll | |
| // RUN: FileCheck --input-file=%t-cir.ll --check-prefix=LLVM %s | |
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +avx512vbmi -emit-llvm %s -o %t.ll | |
| // RUN: FileCheck --input-file=%t.ll --check-prefix=OGCG %s |
These lines perform the three variations of checks we expect.
However, this test should be moved to clang/test/CIR/CodeGenBuiltins/X86/avx512vbmi-builtins.c which is also being added in #169582
You can test this locally with the following command:git-clang-format --diff origin/main HEAD --extensions c,cpp -- clang/test/CIR/CodeGen/X86/avx512vbmi-builtins.c clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp --diff_from_common_commit
View the diff from clang-format here.diff --git a/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp b/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
index 3ad653237..d3979d4ac 100644
--- a/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
@@ -1453,11 +1453,14 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
getContext().BuiltinInfo.getName(builtinID));
return {};
case X86::BI__builtin_ia32_vpmultishiftqb128:
- return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_128", ops[0].getType(), ops);
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_128",
+ ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpmultishiftqb256:
- return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_256", ops[0].getType(), ops);
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_256",
+ ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpmultishiftqb512:
- return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_512", ops[0].getType(), ops);
+ return emitIntrinsicCallOp(*this, expr, "x86_avx512_pmultishift_qb_512",
+ ops[0].getType(), ops);
case X86::BI__builtin_ia32_vpshufbitqmb128_mask:
case X86::BI__builtin_ia32_vpshufbitqmb256_mask:
case X86::BI__builtin_ia32_vpshufbitqmb512_mask:
|
🐧 Linux x64 Test Results
All tests passed but another part of the build failed. Click on a failure below to see the details. tools/clang/lib/CIR/CodeGen/CMakeFiles/obj.clangCIR.dir/CIRGenBuiltinX86.cpp.oIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
Added builtin support for the multishift operation with test file. changes has been done in CIRGenBuiltinX86 file
cs25mtech12008
force-pushed
the
builtin_multishift
branch
from
94c0ba3 to
397436e
Compare
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @cs25mtech12008 anything you need to get unblocked here?
| return _mm512_multishift_epi64_epi8(x, y); | ||
| } | ||
|
|
||
| // // CHECK: cir.func @test_multishift |
Member
There was a problem hiding this comment.
Double // here is not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added builtin support for the multishift operation with test file.
changes has been done in CIRGenBuiltinX86 file
please review the changes and suggest if anything is missing