[CodeGen] Minor refactor of CSRSavedLocation struct [nfc] #170721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add operator==, clarify invariants with an assert. This does convert one llvm_unreachable into an assert which runs earlier in the computation. I don't believe the difference is observable outside debug builds, and should report the fault closer to introduction.
topperc
reviewed
Dec 4, 2025
| } | ||
| if (CSRReg || CSROffset) { | ||
| CSRSavedLocation Loc(CSRReg, CSROffset); | ||
| auto It = CSRLocMap.find(CFI.getRegister()); |
Collaborator
There was a problem hiding this comment.
We should try the insert instead of find here. If the insert fails, do the check to make sure the value we tried to insert matches what was already there.
This can be a follow up.
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
Add operator==, clarify invariants with an assert. This does convert one llvm_unreachable into an assert which runs earlier in the computation. I don't believe the difference is observable outside debug builds, and should report the fault closer to introduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add operator==, clarify invariants with an assert.
This does convert one llvm_unreachable into an assert which runs earlier in the computation. I don't believe the difference is observable outside debug builds, and should report the fault closer to introduction.