Skip to content

[sanitizer_common] child_stdin_fd_ should only be set on posix_spawn path #171508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndrewh merged 1 commit into from
Dec 9, 2025
Merged

[sanitizer_common] child_stdin_fd_ should only be set on posix_spawn path #171508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ bool SymbolizerProcess::StartSymbolizerSubprocess() {
internal_close(outfd[1]);
return false;
}

// We intentionally hold on to the read-end so that we don't get a SIGPIPE
child_stdin_fd_ = outfd[0];

# else // SANITIZER_APPLE
UNIMPLEMENTED();
# endif // SANITIZER_APPLE
Expand All @@ -192,9 +196,6 @@ bool SymbolizerProcess::StartSymbolizerSubprocess() {
input_fd_ = infd[0];
output_fd_ = outfd[1];

// We intentionally hold on to the read-end so that we don't get a SIGPIPE
child_stdin_fd_ = outfd[0];

CHECK_GT(pid, 0);

// Check that symbolizer subprocess started successfully.
Expand Down