Skip to content

[sanitizer_common] Fix SIGPIPE when symbolizer started by StartSubprocess dies #171511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndrewh wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −7
Open

[sanitizer_common] Fix SIGPIPE when symbolizer started by StartSubprocess dies #171511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,6 @@ pid_t StartSubprocess(const char *program, const char *const argv[],
const char *const envp[], fd_t stdin_fd, fd_t stdout_fd,
fd_t stderr_fd) {
auto file_closer = at_scope_exit([&] {
if (stdin_fd != kInvalidFd) {
internal_close(stdin_fd);
}
if (stdout_fd != kInvalidFd) {
internal_close(stdout_fd);
}
Expand Down
6 changes: 2 additions & 4 deletions compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,6 @@ bool SymbolizerProcess::StartSymbolizerSubprocess() {
internal_close(outfd[1]);
return false;
}

// We intentionally hold on to the read-end so that we don't get a SIGPIPE
child_stdin_fd_ = outfd[0];

# else // SANITIZER_APPLE
UNIMPLEMENTED();
# endif // SANITIZER_APPLE
Expand All @@ -195,6 +191,8 @@ bool SymbolizerProcess::StartSymbolizerSubprocess() {

input_fd_ = infd[0];
output_fd_ = outfd[1];
// We intentionally hold on to the read-end so that we don't get a SIGPIPE
child_stdin_fd_ = outfd[0];

CHECK_GT(pid, 0);

Expand Down
Loading