[compiler-rt] Fix usage of stdin/stdout
#171560
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From llvm#170809. Causes compile errors when `stdin`/`stdout` are #defined in stdio.h.
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Arthur Eubanks (aeubanks) ChangesFrom #170809. Causes compile errors when Full diff: https://github.com/llvm/llvm-project/pull/171560.diff 1 Files Affected:
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_posix.h b/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
index 063408b8360c1..dc9c3b8822d30 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
@@ -68,7 +68,7 @@ uptr internal_waitpid(int pid, int *status, int options);
int internal_fork();
bool internal_spawn(const char* argv[], const char* envp[], pid_t* pid,
- fd_t stdin, fd_t stdout);
+ fd_t fd_stdin, fd_t fd_stdout);
int internal_sysctl(const int *name, unsigned int namelen, void *oldp,
uptr *oldlenp, const void *newp, uptr newlen);
|
Contributor
|
Sorry about that, thanks! |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/17867 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #170809.
Causes compile errors when
stdin/stdoutare #defined in stdio.h.