Skip to content

Conversation

@AmrDeveloper
Copy link
Member

Remove duplicate VisitCXXNoexceptExpr to fix building ClangIR

@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Dec 10, 2025
@llvmbot
Copy link
Member

llvmbot commented Dec 10, 2025

@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Amr Hesham (AmrDeveloper)

Changes

Remove duplicate VisitCXXNoexceptExpr to fix building ClangIR


Full diff: https://github.com/llvm/llvm-project/pull/171624.diff

1 Files Affected:

  • (modified) clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp (-4)
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index f1aa42f98dffe..929714e54531e 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -865,10 +865,6 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
     cgf.emitCXXThrowExpr(e);
     return {};
   }
-  mlir::Value VisitCXXNoexceptExpr(CXXNoexceptExpr *e) {
-    cgf.cgm.errorNYI(e->getSourceRange(), "ScalarExprEmitter: cxx noexcept");
-    return {};
-  }
 
   mlir::Value VisitCXXNoexceptExpr(CXXNoexceptExpr *e) {
     return builder.getBool(e->getValue(), cgf.getLoc(e->getExprLoc()));

@AmrDeveloper AmrDeveloper enabled auto-merge (squash) December 10, 2025 14:23
@AmrDeveloper AmrDeveloper merged commit 3ba0ff6 into llvm:main Dec 10, 2025
9 of 12 checks passed
@AmrDeveloper
Copy link
Member Author

Note: I merged to unblock other PR's after testing it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants