[flang] add missing headers in ConvertVariable.h after #171501 #171983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-fir-hlfir Author: None (jeanPerier) ChangesMissing headers were caught by windows build bots:
In #171501, I removed IterationSpace.h include from Utils.h, and IterationSpace.h was itself including SymbolMap.h and FIRBuilder.h that are required here. Full diff: https://github.com/llvm/llvm-project/pull/171983.diff 1 Files Affected:
diff --git a/flang/include/flang/Lower/ConvertVariable.h b/flang/include/flang/Lower/ConvertVariable.h
index 31f3c72c5c86c..e939d8c88c9f9 100644
--- a/flang/include/flang/Lower/ConvertVariable.h
+++ b/flang/include/flang/Lower/ConvertVariable.h
@@ -18,6 +18,8 @@
#define FORTRAN_LOWER_CONVERT_VARIABLE_H
#include "flang/Lower/Support/Utils.h"
+#include "flang/Lower/SymbolMap.h"
+#include "flang/Optimizer/Builder/FIRBuilder.h"
#include "flang/Optimizer/Dialect/FIRAttr.h"
#include "flang/Semantics/symbol.h"
#include "mlir/IR/Value.h"
@@ -27,13 +29,6 @@ namespace cuf {
class DataAttributeAttr;
}
-namespace fir {
-class ExtendedValue;
-class FirOpBuilder;
-class GlobalOp;
-class FortranVariableFlagsAttr;
-} // namespace fir
-
namespace Fortran {
namespace semantics {
class Scope;
|
anonymouspc
pushed a commit
to anonymouspc/llvm
that referenced
this pull request
Dec 15, 2025
…lvm#171983) Missing headers were caught by windows build bots: - https://lab.llvm.org/buildbot/#/builders/222/builds/817/steps/6/logs/stdio - https://lab.llvm.org/buildbot/#/builders/207/builds/10970/steps/5/logs/stdio In llvm#171501, I removed IterationSpace.h include from Utils.h, and IterationSpace.h was itself including SymbolMap.h and FIRBuilder.h that are required here.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Dec 20, 2025
…lvm#171983) Missing headers were caught by windows build bots: - https://lab.llvm.org/buildbot/#/builders/222/builds/817/steps/6/logs/stdio - https://lab.llvm.org/buildbot/#/builders/207/builds/10970/steps/5/logs/stdio In llvm#171501, I removed IterationSpace.h include from Utils.h, and IterationSpace.h was itself including SymbolMap.h and FIRBuilder.h that are required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing headers were caught by windows build bots:
In #171501, I removed IterationSpace.h include from Utils.h, and IterationSpace.h was itself including SymbolMap.h and FIRBuilder.h that are required here.