Skip to content

Conversation

@jeanPerier
Copy link
Contributor

Utils.h included StatementContext.h and FIRBuilder.h indirectly in AbstractConverter.h.
Makes these includes direct.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Dec 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Dec 12, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: None (jeanPerier)

Changes

Utils.h included StatementContext.h and FIRBuilder.h indirectly in AbstractConverter.h.
Makes these includes direct.


Full diff: https://github.com/llvm/llvm-project/pull/171987.diff

1 Files Affected:

  • (modified) flang/include/flang/Lower/AbstractConverter.h (+2-1)
diff --git a/flang/include/flang/Lower/AbstractConverter.h b/flang/include/flang/Lower/AbstractConverter.h
index 8109ebdc75688..1b19807bff0cf 100644
--- a/flang/include/flang/Lower/AbstractConverter.h
+++ b/flang/include/flang/Lower/AbstractConverter.h
@@ -15,9 +15,11 @@
 
 #include "flang/Lower/LoweringOptions.h"
 #include "flang/Lower/PFTDefs.h"
+#include "flang/Lower/StatementContext.h"
 #include "flang/Lower/Support/Utils.h"
 #include "flang/Lower/SymbolMap.h"
 #include "flang/Optimizer/Builder/BoxValue.h"
+#include "flang/Optimizer/Builder/FIRBuilder.h"
 #include "flang/Optimizer/Dialect/FIRAttr.h"
 #include "flang/Semantics/symbol.h"
 #include "flang/Support/Fortran.h"
@@ -34,7 +36,6 @@ class StateStack;
 
 namespace fir {
 class KindMapping;
-class FirOpBuilder;
 } // namespace fir
 
 namespace Fortran {

@jeanPerier jeanPerier enabled auto-merge (squash) December 12, 2025 10:57
@jeanPerier jeanPerier merged commit ad62c04 into llvm:main Dec 12, 2025
11 of 12 checks passed
@jeanPerier jeanPerier deleted the fix_missing_include branch December 12, 2025 13:05
anonymouspc pushed a commit to anonymouspc/llvm that referenced this pull request Dec 15, 2025
…71987)

Utils.h included StatementContext.h and FIRBuilder.h indirectly in AbstractConverter.h.
Makes these includes direct.
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Dec 20, 2025
…71987)

Utils.h included StatementContext.h and FIRBuilder.h indirectly in AbstractConverter.h.
Makes these includes direct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:fir-hlfir flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants