Skip to content

[X86] Convert X86FixupBWInsts from LivePhysRegs to LiveRegUnits. NFCI. #65592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2023
Merged

[X86] Convert X86FixupBWInsts from LivePhysRegs to LiveRegUnits. NFCI. #65592

merged 2 commits into from
Sep 8, 2023

Conversation

jayfoad
Copy link
Contributor

@jayfoad jayfoad commented Sep 7, 2023

This gives a geomean 0.50% speed up according to
https://llvm-compile-time-tracker.com/

@jayfoad jayfoad requested a review from a team as a code owner September 7, 2023 10:04
@jayfoad jayfoad requested a review from nikic September 7, 2023 10:04
RKSimon
RKSimon reviewed Sep 8, 2023
View reviewed changes
RKSimon
RKSimon approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayfoad jayfoad merged commit bd6e77c into llvm:main Sep 8, 2023
@jayfoad jayfoad deleted the x86fixupbwinsts-liveregunits branch September 8, 2023 14:44
@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RKSimon RKSimon RKSimon approved these changes

@nikic nikic Awaiting requested review from nikic

Assignees
No one assigned
Labels
backend:X86
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayfoad @RKSimon