[X86] Do not directly fold for VINSERTPS #65718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have already customized folding for VINSERTPS by 7e6606f, which do the folding when alignment >= 4 bytes. We cannot arbitrarily fold it like others because we need to calculate the source offset.
KanRobert
reviewed
Sep 8, 2023
| NOFOLD(VEXTRACTI64x2Z256rrk) | ||
| NOFOLD(VEXTRACTI64x2Zrrk) | ||
| NOFOLD(VEXTRACTI64x4Zrrk) | ||
| NOFOLD(VINSERTPSZrr) |
There was a problem hiding this comment.
Could you move this to line 239 NOFOLD(INSERTPSrr)? So we share the comments
There was a problem hiding this comment.
Good point, I didn't notice it before
KanRobert
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already customized folding for VINSERTPS by 7e6606f, which do the folding when alignment >= 4 bytes.
We cannot arbitrarily fold it like others because we need to calculate the source offset.