[mlir][spirv] Support spirv.coopmatrix type (de-)serialization
#65831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend SPIR-V target serialization and deserialization to handle coop matrix types. Add a roundtrip test. In addition to `FileCheck` checks, the resulting spirv binary also passes `spir-val` (external tool). Also fix a type attribute bug surfaced by the `CooperativeMatrixLength` op. Multiple matrix operand attributes will be handled in a future patch to reduce the scope.
antiagainst
approved these changes
Sep 11, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…m#65831) Extend SPIR-V target serialization and deserialization to handle coop matrix types. Add a roundtrip test. In addition to `FileCheck` checks, the resulting spirv binary also passes `spir-val` (external tool). Also fix a type attribute bug surfaced by the `CooperativeMatrixLength` op. Multiple matrix operand attributes will be handled in a future patch to reduce the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend SPIR-V target serialization and deserialization to handle coop matrix types. Add a roundtrip test. In addition to
FileCheckchecks, the resulting spirv binary also passesspir-val(external tool).Also fix a type attribute bug surfaced by the
CooperativeMatrixLengthop.Multiple matrix operand attributes will be handled in a future patch to reduce the scope.