[SPIRV] Test basic float and int types #66282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keenuts PTAL These tests are dependent on https://reviews.llvm.org/D156049, so it should be merged after that patch |
Keenuts
reviewed
Sep 14, 2023
sudonatalie
force-pushed
the
basic-types
branch
from
3db1a6a to
82b6e9c
Compare
Keenuts
reviewed
Sep 14, 2023
sudonatalie
force-pushed
the
basic-types
branch
from
82b6e9c to
9438dd5
Compare
Keenuts
approved these changes
Sep 15, 2023
|
Waiting on D156049 before merging. |
Add Int16, Int64 and Float64 capabilities as always available for Vulkan (since 1.0), and add tests covering most of the basic types from clang/test/CodeGenHLSL/basic_types.hlsl except for half floats. Depends on D156049
sudonatalie
force-pushed
the
basic-types
branch
from
9438dd5 to
7755529
Compare
This was referenced Sep 19, 2023
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Int16, Int64 and Float64 capabilities as always available for Vulkan (since 1.0), and add tests covering most of the basic types from clang/test/CodeGenHLSL/basic_types.hlsl except for half floats.
Depends on D156049