Skip to content

[NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes #66295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2023
Merged

[NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes #66295

merged 4 commits into from
Sep 14, 2023

Conversation

aeubanks
Copy link
Contributor

@aeubanks aeubanks commented Sep 13, 2023 •
edited
Loading

This will make it easy for callers to see issues with and fix up calls
to createTargetMachine after a future change to the params of
TargetMachine.

This matches other nearby enums.

For downstream users, this should be a fairly straightforward replacement,
e.g. s/CodeGenOpt::Aggressive/CodeGenOptLevel::Aggressive
or s/CGFT_/CodeGenFileType::

@aeubanks
[NFC][CodeGen] Change CodeGenOpt::{Level,FileType} into enum classes
855e4ce 
This will make it easy for callers to see issues with and fix up calls
to createTargetMachine after a future change to the params of
TargetMachine.

This matches other enums in the CodeGenOpt namespace.

For downstream users, this should be a fairly straightforward replacement,
e.g. s/CodeGenOpt::Aggressive/CodeGenOpt::Level::Aggressive
or s/CodeGenOpt::CGFT_Null/CodeGenOpt::FileType::Null
@aeubanks aeubanks requested review from a team as code owners September 13, 2023 21:39
piotrAMD added a commit to GPUOpen-Drivers/llpc that referenced this pull request Sep 19, 2023
@piotrAMD
Update CodeGenOpt
e60c1cc 
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Update the code to use both old and new schemes depending on the LLVM version used.

Change enum to uint32_t in some places to reduce the number of include guards.
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Sep 22, 2023
@modiking @pytorchmergebot
Update caffe2 with LLVM-18 API change (#109408)
f0d71de 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: #109408
Approved by: https://github.com/Skylion007
dstutt added a commit to dstutt/llpc that referenced this pull request Sep 27, 2023
@dstutt
Update CodeGenOpt unit tests
2b079c9 
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in GPUOpen-Drivers#2770 but some
unit tests were missed.
@dstutt dstutt mentioned this pull request Sep 27, 2023
Merged
dstutt added a commit to GPUOpen-Drivers/llpc that referenced this pull request Sep 28, 2023
@dstutt
Update CodeGenOpt unit tests (#2734)
6ca60f4 
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in #2707 but some
unit tests were missed.
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Oct 4, 2023
@modiking @jeffdaily
Update caffe2 with LLVM-18 API change (pytorch#109408)
a49a6a0 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: pytorch#109408
Approved by: https://github.com/Skylion007
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Oct 4, 2023
@modiking @jeffdaily
Update caffe2 with LLVM-18 API change (pytorch#109408)
ffae55f 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: pytorch#109408
Approved by: https://github.com/Skylion007
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Oct 6, 2023
@modiking @pruthvistony
Update caffe2 with LLVM-18 API change (pytorch#109408)
308bd89 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: pytorch#109408
Approved by: https://github.com/Skylion007
quic-sanirudh added a commit to quic-sanirudh/tvm that referenced this pull request Oct 12, 2023
@quic-sanirudh
[LLVM] Fix for llvm CodeGenOpt API change
7648e14 
This patch fixes the errors caused due to recent API change from LLVM
for CodeGenOpt made in [this PR](llvm/llvm-project#66295)
@quic-sanirudh quic-sanirudh mentioned this pull request Oct 12, 2023
Merged
Hzfengsy pushed a commit to apache/tvm that referenced this pull request Oct 13, 2023
@quic-sanirudh
[LLVM] Fix for llvm CodeGenOpt API change (#15921)
71caa19 
This patch fixes the errors caused due to recent API change from LLVM
for CodeGenOpt made in [this PR](llvm/llvm-project#66295)
@aeubanks aeubanks mentioned this pull request Nov 15, 2023
Merged
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Nov 17, 2023
@modiking @jeffdaily
Update caffe2 with LLVM-18 API change (pytorch#109408)
8eff393 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: pytorch#109408
Approved by: https://github.com/Skylion007
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Jan 5, 2024
@modiking @jeffdaily
Update caffe2 with LLVM-18 API change (pytorch#109408)
69cf1b8 
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard

Test Plan: CI

Differential Revision: D49340871

Pull Request resolved: pytorch#109408
Approved by: https://github.com/Skylion007
Zentrik added a commit to Zentrik/julia that referenced this pull request Apr 21, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
45ab39a 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Apr 21, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
d65636f 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request May 3, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
c0d4ae5 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request May 3, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
cc82af6 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request May 4, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
026dc74 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request May 4, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
c281007 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 18, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
da3c8f4 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 18, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
9965c8f 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 20, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
c3ecf6f 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 20, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
75d280d 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 21, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
890f6f7 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jun 21, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
ae2811c 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jul 21, 2024
@Zentrik
Update CodeGenOpt to CodeGenOptLevel
3f21a13 
See llvm/llvm-project#66295
Zentrik added a commit to Zentrik/julia that referenced this pull request Jul 21, 2024
@Zentrik
Update CGFT_*File to CodeGenFileType
f43fa7b 
See llvm/llvm-project#66295
hubot pushed a commit to google/swiftshader that referenced this pull request Apr 28, 2025
@brjsp
Make Reactor buildable with LLVM 18
90d72a2 
Relevant LLVM API changes:
llvm/llvm-project#66295
llvm/llvm-project#71029
llvm/llvm-project#74261

Change-Id: Id5af421c1415cf231dcb6673fa3c3b6f5b106841
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/73168
Reviewed-by: Geoff Lang <geofflang@google.com>
Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pogo59 pogo59 pogo59 left review comments

@rnk rnk rnk approved these changes

@MaskRay MaskRay MaskRay approved these changes

@banach-space banach-space banach-space approved these changes

@mshockwave mshockwave mshockwave approved these changes

@joker-eph joker-eph joker-eph approved these changes

@mtrofin mtrofin mtrofin approved these changes

@efriedma-quic efriedma-quic Awaiting requested review from efriedma-quic

Assignees
No one assigned
Labels
backend:AArch64 backend:AMDGPU backend:ARM backend:DirectX backend:loongarch backend:m68k backend:MSP430 backend:RISC-V backend:Sparc backend:WebAssembly backend:X86 clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category debuginfo flang:driver flang:openmp flang Flang issues not falling into any other category libc++abi libc++abi C++ Runtime Library. Not libc++. lld:COFF lld:ELF lld:MachO lld:wasm lld lldb llvm:globalisel llvm:SelectionDAG SelectionDAGISel as well LTO Link time optimization (regular/full LTO or ThinLTO) mlir:core MLIR Core Infrastructure mlir:execution-engine mlir:gpu mlir:llvm mlir platform:windows tools:llvm-exegesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aeubanks @llvmbot @ldionne @rnk @MaskRay @banach-space @mshockwave @joker-eph @mtrofin @pogo59