[mlir][TilingInterface] Make the tiling set tile sizes function use OpFoldResult.
#66566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
force-pushed
the
mahesh_use_scfforall
branch
from
4ffecd8 to
9caa02e
Compare
MaheshRavishankar
requested review from
nicolasvasilache,
matthias-springer,
chelini and
qedawkins
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 16, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 16, 2023
qedawkins
approved these changes
Sep 16, 2023
| SmallVector<OpFoldResult> &sizes) { | ||
| static SmallVector<scf::ForOp> generateTileLoopNest( | ||
| OpBuilder &builder, Location loc, ArrayRef<Range> loopRanges, | ||
| ArrayRef<OpFoldResult> tileSizeVals, SmallVector<OpFoldResult> &offsets, |
There was a problem hiding this comment.
nit: tileSizeVals -> tileSizes.
chelini
approved these changes
Sep 17, 2023
MaheshRavishankar
force-pushed
the
mahesh_use_scfforall
branch
3 times, most recently
from
2cbb94a to
24738d8
Compare
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
force-pushed
the
mahesh_use_scfforall
branch
from
24738d8 to
dea0b83
Compare
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
force-pushed
the
mahesh_use_scfforall
branch
from
dea0b83 to
63c3a8e
Compare
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 18, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
This was referenced Sep 19, 2023
MaheshRavishankar
added a commit
to iree-org/iree
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.