[lldb][NFCI] Remove unneeded ConstString from intel-pt plugin

[bulbazord]

This is a follow-up to 14d95b2. I would have changed it in that commit, but I don't build the intel-pt plugin so I didn't see this until later.

[llvmbot]

@llvm/pr-subscribers-lldb

Changes

This is a follow-up to 14d95b2. I would have changed it in that commit, but I don't build the intel-pt plugin so I didn't see this until later.

---

Full diff: https://github.com/llvm/llvm-project/pull/66721.diff

2 Files Affected:

• (modified) lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp (+2-2)
• (modified) lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h (+1-1)

diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
index bcac731713bb24b..015faa89fcfada8 100644
--- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
+++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
@@ -48,8 +48,8 @@ enum {
 #include "TraceIntelPTPropertiesEnum.inc"
 };
 
-ConstString TraceIntelPT::PluginProperties::GetSettingName() {
-  return ConstString(TraceIntelPT::GetPluginNameStatic());
+llvm::StringRef TraceIntelPT::PluginProperties::GetSettingName() {
+  return TraceIntelPT::GetPluginNameStatic();
 }
 
 TraceIntelPT::PluginProperties::PluginProperties() : Properties() {
diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
index 20faabdce790241..da9cefe9ed95d67 100644
--- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
+++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
@@ -26,7 +26,7 @@ class TraceIntelPT : public Trace {
   /// Properties to be used with the `settings` command.
   class PluginProperties : public Properties {
   public:
-    static ConstString GetSettingName();
+    static llvm::StringRef GetSettingName();
 
     PluginProperties();