Skip to content

[RISCV] Add missing V extensions for zvk-invalid-features.c #66875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

4vtomat
Copy link
Member

@4vtomat 4vtomat commented Sep 20, 2023

If we don't include riscv_vector.h, even we add the target-feature,
it still can't find the intrinsic interface.

@4vtomat 4vtomat requested a review from a team September 20, 2023 08:53
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 20, 2023
@llvmbot
Copy link
Member

llvmbot commented Sep 20, 2023

@llvm/pr-subscribers-clang

Changes

If we don't include riscv_vector.h, even we add the target-feature,
it still can't find the intrinsic interface.


Full diff: https://github.com/llvm/llvm-project/pull/66875.diff

1 Files Affected:

  • (modified) clang/test/Sema/zvk-invalid-features.c (+3-1)
diff --git a/clang/test/Sema/zvk-invalid-features.c b/clang/test/Sema/zvk-invalid-features.c
index be1170df8f0c719..05dd6498ce01ec9 100644
--- a/clang/test/Sema/zvk-invalid-features.c
+++ b/clang/test/Sema/zvk-invalid-features.c
@@ -1,5 +1,7 @@
 // REQUIRES: riscv-registered-target
-// RUN: %clang_cc1 -triple riscv64 %s -fsyntax-only -verify
+// RUN: %clang_cc1 -triple riscv64 %s -target-feature +v -fsyntax-only -verify
+
+#include <riscv_vector.h>
 
 void test_zvk_features() {
   // zvbb

@jacquesguan
Copy link
Contributor

LGTM

If we don't include riscv_vector.h, even we add the target-feature,
it still can't find the intrinsic interface.
@4vtomat 4vtomat force-pushed the add_missing_include_to_zvk_sema branch from fdf29e4 to f2321c3 Compare September 20, 2023 10:23
@4vtomat 4vtomat merged commit 97ae760 into llvm:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants