[libc++] LWG 3821 uses_allocator_construction_args should have overload for pair-like #66939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
huixie90
force-pushed
the
pair_range
branch
from
cf670ae to
e3c712d
Compare
ldionne
requested changes
Sep 21, 2023
.../memory/allocator.uses/allocator.uses.construction/uses_allocator_construction_args.pass.cpp
Show resolved
Hide resolved
huixie90
force-pushed
the
pair_range
branch
from
e3c712d to
5995e6c
Compare
ldionne
requested changes
Sep 27, 2023
.../memory/allocator.uses/allocator.uses.construction/uses_allocator_construction_args.pass.cpp
Outdated
Show resolved
Hide resolved
.../memory/allocator.uses/allocator.uses.construction/uses_allocator_construction_args.pass.cpp
Outdated
Show resolved
Hide resolved
ldionne
approved these changes
Oct 2, 2023
|
LGTM. Please squash and merge once CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses LWG 3821 and LWG 3677.
std::pair's constructor no longer takessubrangeuses_allocator_construction_argsconstraint changes w.r.t topair-liketypesuses_allocator_construction_argsconstraints checksis-pair-like<remove_cv_t<T>>