Skip to content

[AArch64] Stack probing for dynamic allocas in GlobalISel #67123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,8 @@ class LegalizerHelper {
LegalizeResult lowerUnmergeValues(MachineInstr &MI);
LegalizeResult lowerExtractInsertVectorElt(MachineInstr &MI);
LegalizeResult lowerShuffleVector(MachineInstr &MI);
Register getDynStackAllocTargetPtr(Register SPReg, Register AllocSize,
Align Alignment, LLT PtrTy);
LegalizeResult lowerDynStackAlloc(MachineInstr &MI);
LegalizeResult lowerStackSave(MachineInstr &MI);
LegalizeResult lowerStackRestore(MachineInstr &MI);
Expand Down
37 changes: 23 additions & 14 deletions llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7042,21 +7042,12 @@ LegalizerHelper::lowerShuffleVector(MachineInstr &MI) {
return Legalized;
}

LegalizerHelper::LegalizeResult
LegalizerHelper::lowerDynStackAlloc(MachineInstr &MI) {
const auto &MF = *MI.getMF();
const auto &TFI = *MF.getSubtarget().getFrameLowering();
if (TFI.getStackGrowthDirection() == TargetFrameLowering::StackGrowsUp)
return UnableToLegalize;

Register Dst = MI.getOperand(0).getReg();
Register AllocSize = MI.getOperand(1).getReg();
Align Alignment = assumeAligned(MI.getOperand(2).getImm());

LLT PtrTy = MRI.getType(Dst);
Register LegalizerHelper::getDynStackAllocTargetPtr(Register SPReg,
Register AllocSize,
Align Alignment,
LLT PtrTy) {
LLT IntPtrTy = LLT::scalar(PtrTy.getSizeInBits());

Register SPReg = TLI.getStackPointerRegisterToSaveRestore();
auto SPTmp = MIRBuilder.buildCopy(PtrTy, SPReg);
SPTmp = MIRBuilder.buildCast(IntPtrTy, SPTmp);

Expand All @@ -7071,7 +7062,25 @@ LegalizerHelper::lowerDynStackAlloc(MachineInstr &MI) {
Alloc = MIRBuilder.buildAnd(IntPtrTy, Alloc, AlignCst);
}

SPTmp = MIRBuilder.buildCast(PtrTy, Alloc);
return MIRBuilder.buildCast(PtrTy, Alloc).getReg(0);
}

LegalizerHelper::LegalizeResult
LegalizerHelper::lowerDynStackAlloc(MachineInstr &MI) {
const auto &MF = *MI.getMF();
const auto &TFI = *MF.getSubtarget().getFrameLowering();
if (TFI.getStackGrowthDirection() == TargetFrameLowering::StackGrowsUp)
return UnableToLegalize;

Register Dst = MI.getOperand(0).getReg();
Register AllocSize = MI.getOperand(1).getReg();
Align Alignment = assumeAligned(MI.getOperand(2).getImm());

LLT PtrTy = MRI.getType(Dst);
Register SPReg = TLI.getStackPointerRegisterToSaveRestore();
Register SPTmp =
getDynStackAllocTargetPtr(SPReg, AllocSize, Alignment, PtrTy);

MIRBuilder.buildCopy(SPReg, SPTmp);
MIRBuilder.buildCopy(Dst, SPTmp);

Expand Down
47 changes: 44 additions & 3 deletions llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -934,9 +934,9 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)

getActionDefinitionsBuilder(G_BRJT).legalFor({{p0, s64}});

getActionDefinitionsBuilder({G_DYN_STACKALLOC,
G_STACKSAVE,
G_STACKRESTORE}).lower();
getActionDefinitionsBuilder(G_DYN_STACKALLOC).custom();

getActionDefinitionsBuilder({G_STACKSAVE, G_STACKRESTORE}).lower();

if (ST.hasMOPS()) {
// G_BZERO is not supported. Currently it is only emitted by
Expand Down Expand Up @@ -1174,6 +1174,8 @@ bool AArch64LegalizerInfo::legalizeCustom(LegalizerHelper &Helper,
return legalizeFCopySign(MI, Helper);
case TargetOpcode::G_EXTRACT_VECTOR_ELT:
return legalizeExtractVectorElt(MI, MRI, Helper);
case TargetOpcode::G_DYN_STACKALLOC:
return legalizeDynStackAlloc(MI, Helper);
}

llvm_unreachable("expected switch to return");
Expand Down Expand Up @@ -1945,3 +1947,42 @@ bool AArch64LegalizerInfo::legalizeExtractVectorElt(
return Helper.lowerExtractInsertVectorElt(MI) !=
LegalizerHelper::LegalizeResult::UnableToLegalize;
}

bool AArch64LegalizerInfo::legalizeDynStackAlloc(
MachineInstr &MI, LegalizerHelper &Helper) const {
MachineFunction &MF = *MI.getParent()->getParent();
MachineIRBuilder &MIRBuilder = Helper.MIRBuilder;
MachineRegisterInfo &MRI = *MIRBuilder.getMRI();

// If stack probing is not enabled for this function, use the default
// lowering.
if (!MF.getFunction().hasFnAttribute("probe-stack") ||
MF.getFunction().getFnAttribute("probe-stack").getValueAsString() !=
"inline-asm") {
Helper.lowerDynStackAlloc(MI);
return true;
}

Register Dst = MI.getOperand(0).getReg();
Register AllocSize = MI.getOperand(1).getReg();
Align Alignment = assumeAligned(MI.getOperand(2).getImm());

assert(MRI.getType(Dst) == LLT::pointer(0, 64) &&
"Unexpected type for dynamic alloca");
assert(MRI.getType(AllocSize) == LLT::scalar(64) &&
"Unexpected type for dynamic alloca");

LLT PtrTy = MRI.getType(Dst);
Register SPReg =
Helper.getTargetLowering().getStackPointerRegisterToSaveRestore();
Register SPTmp =
Helper.getDynStackAllocTargetPtr(SPReg, AllocSize, Alignment, PtrTy);
auto NewMI =
MIRBuilder.buildInstr(AArch64::PROBED_STACKALLOC_DYN, {}, {SPTmp});
MRI.setRegClass(NewMI.getReg(0), &AArch64::GPR64commonRegClass);
MIRBuilder.setInsertPt(*NewMI->getParent(), NewMI);
MIRBuilder.buildCopy(Dst, SPTmp);

MI.eraseFromParent();
return true;
}
1 change: 1 addition & 0 deletions llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class AArch64LegalizerInfo : public LegalizerInfo {
bool legalizeFCopySign(MachineInstr &MI, LegalizerHelper &Helper) const;
bool legalizeExtractVectorElt(MachineInstr &MI, MachineRegisterInfo &MRI,
LegalizerHelper &Helper) const;
bool legalizeDynStackAlloc(MachineInstr &MI, LegalizerHelper &Helper) const;
const AArch64Subtarget *ST;
};
} // End llvm namespace.
Expand Down
Loading