[clang-repl] Disable InterpreterExceptionTest on RISC-V #68216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. llvm#66067 is proposed to address this. Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64.
|
@llvm/pr-subscribers-clang ChangesThis test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this. Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the test always failed, it just wasn't run until now, I think skipping is the correct interim approach (as is already done for Arm, Darwin, and others). Full diff: https://github.com/llvm/llvm-project/pull/68216.diff 1 Files Affected:
diff --git a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
index 2f1c4efb381f00b..7b47d93446192ba 100644
--- a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
+++ b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
@@ -122,6 +122,11 @@ extern "C" int throw_exception() {
Triple.getArch() == llvm::Triple::aarch64_32))
GTEST_SKIP();
+ // FIXME: RISC-V fails as .eh_frame handling is not yet implemented in
+ // JITLink for RISC-V. See PR #66067.
+ if (Triple.isRISCV())
+ GTEST_SKIP();
+
llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));
testing::internal::CaptureStdout();
auto ThrowException =
|
mtvec
approved these changes
Oct 4, 2023
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 12, 2023
Local branch amd-gfx a86283a Merged main:e00f2272d640 into amd-gfx:7a55dcafa40e Remote branch main ca003ee [clang-repl] Disable InterpreterExceptionTest on RISC-V (llvm#68216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this.
Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the test always failed, it just wasn't run until now, I think skipping is the correct interim approach (as is already done for Arm, Darwin, and others).