Skip to content

[clang][Interp] Fix crash during InterpStack printing #68246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[clang][Interp] Fix crash during InterpStack printing #68246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions clang/lib/AST/Interp/InterpStack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,25 @@ void InterpStack::shrink(size_t Size) {

void InterpStack::dump() const {
#ifndef NDEBUG
llvm::errs() << "Items: " << ItemTypes.size() << ". Size: " << size() << "\n";
llvm::errs() << "Items: " << ItemTypes.size() << ". Size: " << size() << '\n';
if (ItemTypes.empty())
return;

size_t Index = 0;
size_t Offset = align(primSize(ItemTypes[0]));
for (PrimType Ty : ItemTypes) {
llvm::errs() << Index << "/" << Offset << ": ";
TYPE_SWITCH(Ty, {
size_t Offset = 0;

// The type of the item on the top of the stack is inserted to the back
// of the vector, so the iteration has to happen backwards.
for (auto TyIt = ItemTypes.rbegin(); TyIt != ItemTypes.rend(); ++TyIt) {
Offset += align(primSize(*TyIt));

llvm::errs() << Index << '/' << Offset << ": ";
TYPE_SWITCH(*TyIt, {
const T &V = peek<T>(Offset);
llvm::errs() << V;
});
llvm::errs() << "\n";
Offset += align(primSize(Ty));
llvm::errs() << '\n';

++Index;
}
#endif
Expand Down