[mlir][Vector] Add Broadcast -> CastOp reordering to SinkVectorBroadcasting patterns. #68257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
changed the title
MaheshRavishankar
requested review from
antiagainst,
nicolasvasilache and
qedawkins
|
Towards iree-org/iree#15091 |
qedawkins
approved these changes
Oct 4, 2023
…asting patterns. Also fix an issue with sink broadcast across elementwise where `arith.cmpf` is elementwise, but result type is different. The result type is not same as the operand type, creating illegal IR.
MaheshRavishankar
force-pushed
the
mahesh_dequantize_matvec_fix
branch
from
2605dea to
a1e599a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.