Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SystemZ][z/OS] Update lowerCall #68259

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

ysyeda
Copy link
Contributor

@ysyeda ysyeda commented Oct 4, 2023

This PR moves some calculation out of LowerCall and into SystemZXPLINKFrameLowering::processFunctionBeforeFrameFinalized.
We need to make this change because LowerCall isn't invoked for functions that don't have function calls, and it is required for some tooling to work correctly. A function that does not make any calls is required to allocate 32 bytes for the parameter area required by the ABI. However, we allocate 64 bytes because this additional space is utilized by certain tools, like the debugger.

Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@uweigand uweigand merged commit 5c4d35d into llvm:main Oct 5, 2023
@ysyeda ysyeda deleted the ysyeda-lowercall branch October 5, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants