Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables #68264

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables #68264

merged 1 commit into from
Oct 5, 2023

Commits on Oct 5, 2023

  1. [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost varia… 

    …bles

Summary:
There's some logic in the AMDGPU target that manually resets the
requested visibility of certain variables. This was triggering when we
set a constant variable in OpenMP. However, we shouldn't do this for
OpenMP when the variable has the `nohost` type. That implies that the
variable is not visible to the host and therefore does not need to be
visible, so we should respect the original value of it.
    @jhuber6
    jhuber6 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5010ba6 View commit details
    Browse the repository at this point in the history