Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scudo] Fix the use of ASSERT_CAPABILITY in TSD #68273

Merged
merged 3 commits into from
Oct 5, 2023

Commits on Oct 4, 2023

  1. [scudo] Fix the use of ASSERT_CAPABILITY in TSD

    In getCache()/getQuarantineCache(), they return a reference to variable
    guarded by a mutex. After llvm#67776, thread-safey analysis checks if a
    variable return by reference has the lock held. The ASSERT_CAPABILITY
    only claims after calling that function, the lock will be held. But not
    asserting that the lock is held *before* calling that function.
    
    In the patch, we switch to use REQUIRES() and assertLocked() to mark the
    code paths. Also remove the misused ASSERT_CAPABILITY.
    ChiaHungDuan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e2090b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9df9199 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    d963804 View commit details
    Browse the repository at this point in the history