[mlir][Transform] Provide a minimal set of utils that allow implementing a simple transform dialect interpreter pass #68330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
nicolasvasilache
force-pushed
the
flush-simplify-transforms-2
branch
3 times, most recently
from
87a63e8 to
94553f9
Compare
ftynse
reviewed
Oct 5, 2023
Member
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
Could we update InterpreterPassBase to use these and avoid duplication?
mlir/include/mlir/Dialect/Transform/Transforms/TransformInterpreterUtils.h
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Transform/Transforms/TransformInterpreterUtils.h
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Transform/Transforms/TransformInterpreterUtils.h
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Transform/Transforms/TransformInterpreterUtils.h
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
nicolasvasilache
force-pushed
the
flush-simplify-transforms-2
branch
2 times, most recently
from
4aa18c7 to
3ed8d51
Compare
Contributor
Author
Discussed this offline, it seems quite simpler to start a new interpreter pass takes advantage of more recent |
nicolasvasilache
force-pushed
the
flush-simplify-transforms-2
branch
from
3ed8d51 to
45731c5
Compare
ftynse
approved these changes
Oct 6, 2023
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
Outdated
Show resolved
Hide resolved
nicolasvasilache
force-pushed
the
flush-simplify-transforms-2
branch
2 times, most recently
from
46621a3 to
883b4d1
Compare
…ing a simple transform dialect interpreter pass
nicolasvasilache
force-pushed
the
flush-simplify-transforms-2
branch
from
883b4d1 to
cdfa540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.