[mlir][sparse] Fix errors in doc and tests #68641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinying-lisa-li
commented
Oct 9, 2023
| automatically. Within the sparse storage format, we refer to indices that are | ||
| stored explicitly as **coordinates** and offsets into the storage format as | ||
| **positions**. | ||
| automatically. Each dimension could also have an optional `SparseTensorDimSliceAttr`. |
There was a problem hiding this comment.
since slice is not an optional array anymore, I feel like we should talk about it with dimension before going into levels. Please let me know if you have better ideas of where to put it.
aartbik
approved these changes
Oct 9, 2023
| automatically. Within the sparse storage format, we refer to indices that are | ||
| stored explicitly as **coordinates** and offsets into the storage format as | ||
| **positions**. | ||
| automatically. Each dimension could also have an optional `SparseTensorDimSliceAttr`. |
aartbik
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.