Skip to content

[Scalar] Use LLVMContext::MD_mem_parallel_loop_access directly (NFC) #69549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Scalar] Use LLVMContext::MD_mem_parallel_loop_access directly (NFC) #69549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions llvm/lib/Transforms/Scalar/Scalarizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,10 @@ T getWithDefaultOverride(const cl::opt<T> &ClOption,

class ScalarizerVisitor : public InstVisitor<ScalarizerVisitor, bool> {
public:
ScalarizerVisitor(unsigned ParallelLoopAccessMDKind, DominatorTree *DT,
ScalarizerPassOptions Options)
: ParallelLoopAccessMDKind(ParallelLoopAccessMDKind), DT(DT),
ScalarizeVariableInsertExtract(
getWithDefaultOverride(ClScalarizeVariableInsertExtract,
Options.ScalarizeVariableInsertExtract)),
ScalarizerVisitor(DominatorTree *DT, ScalarizerPassOptions Options)
: DT(DT), ScalarizeVariableInsertExtract(getWithDefaultOverride(
ClScalarizeVariableInsertExtract,
Options.ScalarizeVariableInsertExtract)),
ScalarizeLoadStore(getWithDefaultOverride(ClScalarizeLoadStore,
Options.ScalarizeLoadStore)),
ScalarizeMinBits(getWithDefaultOverride(ClScalarizeMinBits,
Expand Down Expand Up @@ -337,8 +335,6 @@ class ScalarizerVisitor : public InstVisitor<ScalarizerVisitor, bool> {

SmallVector<WeakTrackingVH, 32> PotentiallyDeadInstrs;

unsigned ParallelLoopAccessMDKind;

DominatorTree *DT;

const bool ScalarizeVariableInsertExtract;
Expand Down Expand Up @@ -448,8 +444,7 @@ bool ScalarizerLegacyPass::runOnFunction(Function &F) {
return false;

DominatorTree *DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree();
ScalarizerVisitor Impl(LLVMContext::MD_mem_parallel_loop_access, DT,
ScalarizerPassOptions());
ScalarizerVisitor Impl(DT, ScalarizerPassOptions());
return Impl.visit(F);
}

Expand Down Expand Up @@ -556,7 +551,7 @@ bool ScalarizerVisitor::canTransferMetadata(unsigned Tag) {
|| Tag == LLVMContext::MD_invariant_load
|| Tag == LLVMContext::MD_alias_scope
|| Tag == LLVMContext::MD_noalias
|| Tag == ParallelLoopAccessMDKind
|| Tag == LLVMContext::MD_mem_parallel_loop_access
|| Tag == LLVMContext::MD_access_group);
}

Expand Down Expand Up @@ -1253,7 +1248,7 @@ bool ScalarizerVisitor::finish() {

PreservedAnalyses ScalarizerPass::run(Function &F, FunctionAnalysisManager &AM) {
DominatorTree *DT = &AM.getResult<DominatorTreeAnalysis>(F);
ScalarizerVisitor Impl(LLVMContext::MD_mem_parallel_loop_access, DT, Options);
ScalarizerVisitor Impl(DT, Options);
bool Changed = Impl.visit(F);
PreservedAnalyses PA;
PA.preserve<DominatorTreeAnalysis>();
Expand Down