Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Fix using undefined variable %pt2 in mask-reg-alloc.mir testcase #70764

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tclin914
Copy link
Contributor

First PseudoVMERGE_VIM_M1 should use %pt1 as its operand instead of %pt2.

I found this error when I add LiveIntervals analysis pass in my downstream. And it crashes with the message:

Use of %7 does not have a corresponding definition on every path:
112r %6:vrnov0 = PseudoVMERGE_VIM_M1 %pt2:vrnov0(tied-def 0), %2:vr, 1, %4:vmv0, 1, 3
LLVM ERROR: Use not jointly dominated by defs.

First PseudoVMERGE_VIM_M1 should use %pt1 as its operand instead of %pt2.

I found this error when I add LiveIntervals analysis pass in my
downstream. And it crashes with the message:

`Use of %7 does not have a corresponding definition on every path:
 112r %6:vrnov0 = PseudoVMERGE_VIM_M1 %pt2:vrnov0(tied-def 0), %2:vr, 1, %4:vmv0, 1, 3
 LLVM ERROR: Use not jointly dominated by defs.`
@tclin914 tclin914 requested review from preames, topperc and asb October 31, 2023 05:12
@tclin914
Copy link
Contributor Author

tclin914 commented Nov 6, 2023

Kindly ping.

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tclin914 tclin914 merged commit 4306cfd into llvm:main Nov 7, 2023
2 checks passed
@tclin914 tclin914 deleted the mask-reg-alloc-dev branch January 5, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants