[Clang] Remove unneeded template keyword #71435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in this bug report: llvm#37647 Due to this clang bug we added the template keyword in Redeclarable.h. The bug has been fixed since then, so removing it.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) ChangesAs noted in this bug report: #37647 Due to this clang bug we added the template keyword in Redeclarable.h. The bug has been fixed since then, so removing it. Full diff: https://github.com/llvm/llvm-project/pull/71435.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/Redeclarable.h b/clang/include/clang/AST/Redeclarable.h
index 091bb886f2d4962..be022bf5322ad61 100644
--- a/clang/include/clang/AST/Redeclarable.h
+++ b/clang/include/clang/AST/Redeclarable.h
@@ -114,9 +114,7 @@ class Redeclarable {
bool isFirst() const {
return Link.is<KnownLatest>() ||
- // FIXME: 'template' is required on the next line due to an
- // apparent clang bug.
- Link.get<NotKnownLatest>().template is<UninitializedLatest>();
+ Link.get<NotKnownLatest>().is<UninitializedLatest>();
}
decl_type *getPrevious(const decl_type *D) const {
|
|
Sadly this is failing on some build bots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c Not sure why at the moment. Will revert for now. |
shafik
added a commit
that referenced
this pull request
Nov 7, 2023
Reverts #71435 This is failing on some build bots e.g.: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c
This was referenced Nov 8, 2023
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this bug report: #37647
Due to this clang bug we added the template keyword in Redeclarable.h. The bug has been fixed since then, so removing it.