Skip to content

[lldb] Fix assert in ScriptedProcess destructor #71744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[lldb] Fix assert in ScriptedProcess destructor #71744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,12 @@ ScriptedProcess::ScriptedProcess(lldb::TargetSP target_sp,

ScriptedProcess::~ScriptedProcess() {
Clear();
// If the interface is not valid, we can't call Finalize(). When that happens
// it means that the Scripted Process instanciation failed and the
// CreateProcess function returns a nullptr, so no one besides this class
// should have access to that bogus process object.
if (!m_interface_up)
return;
// We need to call finalize on the process before destroying ourselves to
// make sure all of the broadcaster cleanup goes as planned. If we destruct
// this class, then Process::~Process() might have problems trying to fully
Expand Down