Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][AIX] Adjust support of timespec_get test #71827

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jakeegan
Copy link
Member

@jakeegan jakeegan commented Nov 9, 2023

The function timespec_get is not available without an update to the time.h header in AIX 7.3 TL2 (7.3.2.*).

@jakeegan jakeegan self-assigned this Nov 9, 2023
@jakeegan jakeegan requested a review from a team as a code owner November 9, 2023 16:47
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 9, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 9, 2023

@llvm/pr-subscribers-libcxx

Author: Jake Egan (jakeegan)

Changes

The function timespec_get is not available without an update to the time.h header in AIX 7.3 TL2 (7.3.2.*).


Full diff: https://github.com/llvm/llvm-project/pull/71827.diff

1 Files Affected:

  • (modified) libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp (+3-2)
diff --git a/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp b/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
index 9a512f6ccfbd32e..04c4c77edd5ed3d 100644
--- a/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
@@ -11,8 +11,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// XFAIL: LIBCXX-AIX-FIXME
-
 // ::timespec_get is provided by the C library, but it's marked as
 // unavailable until macOS 10.15
 // XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
@@ -20,6 +18,9 @@
 // ::timespec_get is available starting with Android Q (API 29)
 // XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27|28)}}
 
+// ::timespec_get is available starting with AIX 7.3 TL2
+// XFAIL: target={{.+}}-aix{{7.2.*|7.3.0.*|7.3.1.*}}
+
 #include <ctime>
 #include <type_traits>
 

@ldionne ldionne merged commit 67d29fb into llvm:main Nov 9, 2023
4 of 5 checks passed
amilendra added a commit to amilendra/LLVM-embedded-toolchain-for-Arm that referenced this pull request Nov 10, 2023
Resolve conflicts with the changes made by PR #71827.
llvm/llvm-project#71827
amilendra added a commit to ARM-software/LLVM-embedded-toolchain-for-Arm that referenced this pull request Nov 10, 2023
Resolve conflicts with the changes made by PR #71827.
llvm/llvm-project#71827
@jakeegan jakeegan deleted the timespec_get branch November 10, 2023 16:44
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
The function `timespec_get` is not available without an update to the
time.h header in AIX 7.3 TL2 (7.3.2.*).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants