-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++] Remove linux Buildkite builders entirely #73825
Conversation
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-libcxx Author: Eric (EricWF) ChangesFull diff: https://github.com/llvm/llvm-project/pull/73825.diff 2 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index dccfe54d4646767..5204fb4569ed309 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -158,6 +158,10 @@ jobs:
'generic-no-wide-characters',
'generic-static',
'generic-with_llvm_unwinder'
+ # TODO Find a better place for the benchmark and bootstrapping builds to live. They're either very expensive
+ # or don't provide much value since the benchmark run results are too noise on the bots.
+ 'benchmarks',
+ 'bootstrapping-build',
]
machine: [ 'libcxx-runners-8' ]
std_modules: [ 'OFF' ]
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 3c49247ab5aeeb9..7077f754220eb21 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -101,20 +101,6 @@ environment_definitions:
steps:
-- label: Bootstrapping build
- command: libcxx/utils/ci/run-buildbot bootstrapping-build
- env:
- <<: *common_env
- <<: *linux_agent
- <<: *common
-
-- label: Benchmarks
- command: libcxx/utils/ci/run-buildbot benchmarks
- env:
- <<: *common_env
- <<: *linux_agent
- <<: *common
-
- group: ':windows: Windows'
steps:
- label: Clang-cl (DLL)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to commit this once the bots come back green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the cleanup, this was on my list! This should allow dropping the GCE runners on Linux altogether, right? Might be worth recording that benefit in the commit message.
Sounds good. I'm working on moving the android builders too, and I'll be happy to help you move the mac builders too. |
Submitting before the bots come back so I can stop wasting resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This removes the Google hosted Linux buildkite builders. We have since moved all of them over to github actions.
Follow up changes will be sent for android.