Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][DWARF] Add support to create path #73884

Merged
merged 1 commit into from
Nov 30, 2023
+18 −0
Merged

[BOLT][DWARF] Add support to create path #73884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bolt/lib/Rewrite/DWARFRewriter.cpp
View file
Original file line number Diff line number Diff line change
@@ -679,6 +679,8 @@ void DWARFRewriter::updateDebugInfo() {
assert(CompDirAttrInfo && "DW_AT_comp_dir is not in Skeleton CU.");

if (!opts::DwarfOutputPath.empty()) {
if (!sys::fs::exists(opts::DwarfOutputPath))
sys::fs::create_directory(opts::DwarfOutputPath);
addStringHelper(DIEBldr, UnitDIE, Unit, CompDirAttrInfo,
opts::DwarfOutputPath.c_str());
}
16 changes: 16 additions & 0 deletions bolt/test/X86/dwarf5-df-output-dir-same-name.test
View file
Original file line number Diff line number Diff line change
@@ -21,3 +21,19 @@
; BOLT: split.dwo1.dwo
; BOLT: DW_AT_dwo_name ("split.dwo0.dwo")
; BOLT: DW_AT_dwo_name ("split.dwo1.dwo")

; Tests that when --dwarf-output-path is specified, but path do not exist BOLT creates it.

; RUN: rm -rf dwo
; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections --dwarf-output-path=%t/dwo
; RUN: ls -l %t/dwo > log
; RUN: llvm-dwarfdump --debug-info main.exe.bolt >> log
; RUN: cat log | FileCheck -check-prefix=BOLT1 %s

; Tests that BOLT handles correctly writing out .dwo files to the same directory when input has input where part of path
; is in DW_AT_dwo_name and the .dwo file names are the same.

; BOLT1: split.dwo0.dwo
; BOLT1: split.dwo1.dwo
; BOLT1: DW_AT_dwo_name ("split.dwo0.dwo")
; BOLT1: DW_AT_dwo_name ("split.dwo1.dwo")