[libc++abi] Improve error message when libunwind is missing from LLVM_ENABLE_RUNTIMES #77991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libcxxabi Author: Louis Dionne (ldionne) ChangesFull diff: https://github.com/llvm/llvm-project/pull/77991.diff 1 Files Affected:
diff --git a/libcxxabi/CMakeLists.txt b/libcxxabi/CMakeLists.txt
index c62b05bf2feafc..9d8bfa548b0125 100644
--- a/libcxxabi/CMakeLists.txt
+++ b/libcxxabi/CMakeLists.txt
@@ -47,6 +47,9 @@ option(LIBCXXABI_ENABLE_ASSERTIONS "Enable assertions independent of build mode.
option(LIBCXXABI_ENABLE_PEDANTIC "Compile with pedantic enabled." OFF)
option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." ON)
+if (LIBCXXABI_USE_LLVM_UNWINDER AND NOT "libunwind" IN_LIST LLVM_ENABLE_RUNTIMES)
+ message(FATAL_ERROR "LIBCXXABI_USE_LLVM_UNWINDER is set to ON, but libuwnind is not specified in LLVM_ENABLE_RUNTIMES.")
+endif()
option(LIBCXXABI_ENABLE_STATIC_UNWINDER "Statically link the LLVM unwinder." OFF)
option(LIBCXXABI_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
option(LIBCXXABI_ENABLE_THREADS "Build with threads enabled" ON)
|
|
I'll merge this since this has been widely requested. |
|
I guess they needs I think patches like this needs to be landed like: This brakeage is too early. Leaving bots broken for a long time will likely hide other regression, which make hard for bot maintainers to pinpoint the cause. |
vitalybuka
added a commit
that referenced
this pull request
Jan 15, 2024
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jan 16, 2024
Revert "[libc++abi] Improve error message when libunwind is missing from LLVM_ENABLE_RUNTIMES (llvm#77991)" Change-Id: Ie6dcb219cff4beac5b6cf6d9fafc5757cc7a08e3
|
The only two bots I still see failing are: I already fixed the first one on llvm-zorg, and I can't find where the second one is defined, but the bot owner is aware of the problem. @vitalybuka Is there still a need to revert this? |
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jan 16, 2024
…_ENABLE_RUNTIMES (llvm#77991) This doesn't actually prevent the build from failing, but it provides a better diagnostic that explains what is needed in order to fix the build. Fixes llvm#77846 Fixes llvm#77843 Change-Id: I4ad40d4c7ba2472ff75bf4c20cba1f9034507a75
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
…_ENABLE_RUNTIMES (llvm#77991) This doesn't actually prevent the build from failing, but it provides a better diagnostic that explains what is needed in order to fix the build. Fixes llvm#77846 Fixes llvm#77843
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually prevent the build from failing, but it provides a better
diagnostic that explains what is needed in order to fix the build.
Fixes #77846
Fixes #77843