Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLDB] Default implementation for pack indexing types. #79695

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

cor3ntin
Copy link
Contributor

We do not handle these types yet but we add them to some switch statement to ensure CI build does not fail.

We do not handle these types yet but we add them to
some switch statement to ensure CI build does not fail.
@llvmbot
Copy link
Member

llvmbot commented Jan 27, 2024

@llvm/pr-subscribers-lldb

Author: cor3ntin (cor3ntin)

Changes

We do not handle these types yet but we add them to some switch statement to ensure CI build does not fail.


Full diff: https://github.com/llvm/llvm-project/pull/79695.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+12)
diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 6f5ff105477be1..4ceeb624e08888 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -4189,6 +4189,10 @@ TypeSystemClang::GetTypeClass(lldb::opaque_compiler_type_t type) {
   case clang::Type::ConstantMatrix:
   case clang::Type::DependentSizedMatrix:
     break;
+
+  // We don't handle pack indexing yet
+  case clang::Type::PackIndexing:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
@@ -5066,6 +5070,10 @@ lldb::Encoding TypeSystemClang::GetEncoding(lldb::opaque_compiler_type_t type,
   case clang::Type::ConstantMatrix:
   case clang::Type::DependentSizedMatrix:
     break;
+
+  // We don't handle pack indexing yet
+  case clang::Type::PackIndexing:
+    break;
   }
   count = 0;
   return lldb::eEncodingInvalid;
@@ -5221,6 +5229,10 @@ lldb::Format TypeSystemClang::GetFormat(lldb::opaque_compiler_type_t type) {
   case clang::Type::ConstantMatrix:
   case clang::Type::DependentSizedMatrix:
     break;
+
+  // We don't handle pack indexing yet
+  case clang::Type::PackIndexing:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eFormatBytes;

@cor3ntin
Copy link
Contributor Author

@DamonFool Can you review that for me? Thanks!

@cor3ntin
Copy link
Contributor Author

I am landing this as to fix the CI build quickly
Feel free to do a post-commit review!

@cor3ntin cor3ntin merged commit 57a20d2 into llvm:main Jan 27, 2024
5 checks passed
@cor3ntin cor3ntin deleted the fix_asan branch January 27, 2024 15:25
@DamonFool
Copy link
Member

@DamonFool Can you review that for me? Thanks!

ninja check-lldb passed on Linux/x64.
So I think it's fine.
Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants