Skip to content

[libc++][test] Fix MSVC warning C4127 in array.cons/initialization.pass.cpp #79793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2024
Merged

[libc++][test] Fix MSVC warning C4127 in array.cons/initialization.pass.cpp #79793

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e81886
Fix MSVC warning C4127: conditional expression is constant
StephanTLavavej Jan 29, 2024
7971433
clang-format.
StephanTLavavej Jan 29, 2024
ea8123f
Merge branch 'main' into conditional-expression-is-constant
StephanTLavavej Mar 8, 2024
4e4ffff
De Morgan the condition.
StephanTLavavej Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions libcxx/test/std/containers/sequences/array/array.cons/initialization.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ struct test_initialization {
// Before C++20, default initialization doesn't work inside constexpr for
// trivially default constructible types. This only apply to non-empty arrays,
// since empty arrays don't hold an element of type T.
if (TEST_STD_AT_LEAST_20_OR_RUNTIME_EVALUATED || !std::is_trivially_default_constructible<T>::value) {
std::array<T, 1> a1; (void)a1;
std::array<T, 2> a2; (void)a2;
std::array<T, 3> a3; (void)a3;
#if TEST_STD_VER < 20
if (!(TEST_IS_CONSTANT_EVALUATED && std::is_trivially_default_constructible<T>::value))
#endif
{
std::array<T, 1> a1;
(void)a1;
std::array<T, 2> a2;
(void)a2;
std::array<T, 3> a3;
(void)a3;
}

std::array<NoDefault, 0> nodefault; (void)nodefault;
Expand Down