Skip to content

[clangd] Implement simple folding of preprocessor branches #80592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions clang-tools-extra/clangd/SemanticSelection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,24 @@ getFoldingRanges(const std::string &Code, bool LineFoldingOnly) {
auto EndPosition = [&](const pseudo::Token &T) {
return offsetToPosition(Code, EndOffset(T));
};

// Preprocessor directives
auto PPRanges = pseudo::pairDirectiveRanges(DirectiveStructure, OrigStream);
for (const auto &R : PPRanges) {
auto BTok = OrigStream.tokens()[R.Begin];
auto ETok = OrigStream.tokens()[R.End];
if (ETok.Kind == tok::eof)
continue;
if (BTok.Line >= ETok.Line)
continue;

Position Start = EndPosition(BTok);
Position End = StartPosition(ETok);
if (LineFoldingOnly)
End.line--;
AddFoldingRange(Start, End, FoldingRange::REGION_KIND);
}

auto Tokens = ParseableStream.tokens();
// Brackets.
for (const auto &Tok : Tokens) {
Expand Down
3 changes: 3 additions & 0 deletions clang-tools-extra/pseudo/include/clang-pseudo/DirectiveTree.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ llvm::raw_ostream &operator<<(llvm::raw_ostream &,
/// The choices are stored in Conditional::Taken nodes.
void chooseConditionalBranches(DirectiveTree &, const TokenStream &Code);

std::vector<Token::Range> pairDirectiveRanges(const DirectiveTree &Tree,
const TokenStream &Code);

} // namespace pseudo
} // namespace clang

Expand Down
54 changes: 54 additions & 0 deletions clang-tools-extra/pseudo/lib/DirectiveTree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -353,5 +353,59 @@ TokenStream DirectiveTree::stripDirectives(const TokenStream &In) const {
return Out;
}

namespace {
class RangePairer {
std::vector<Token::Range> &Ranges;

public:
RangePairer(std::vector<Token::Range> &Ranges) : Ranges(Ranges) {}

void walk(const DirectiveTree &T) {
for (const auto &C : T.Chunks)
std::visit(*this, C);
}

void operator()(const DirectiveTree::Code &C) {}

void operator()(const DirectiveTree::Directive &) {}

void operator()(const DirectiveTree::Conditional &C) {
Token::Range Range;
Token::Index Last;
auto First = true;
for (const auto &B : C.Branches) {
if (First) {
First = false;
} else {
Range = {Last, B.first.Tokens.Begin};
Ranges.push_back(Range);
}
Last = B.first.Tokens.Begin;
}
Range = {Last, C.End.Tokens.Begin};
Ranges.push_back(Range);

for (const auto &B : C.Branches)
walk(B.second);
}
};
} // namespace

std::vector<Token::Range> pairDirectiveRanges(const DirectiveTree &Tree,
const TokenStream &Code) {
std::vector<Token::Range> Ranges;
RangePairer(Ranges).walk(Tree);

// Transform paired ranges to start with last token in its logical line
for (auto &R : Ranges) {
const Token *Tok = &Code.tokens()[R.Begin + 1];
while (Tok->Kind != tok::eof && !Tok->flag(LexFlags::StartsPPLine))
++Tok;
Tok = Tok - 1;
R.Begin = Tok->OriginalIndex;
}
return std::move(Ranges);
}

} // namespace pseudo
} // namespace clang