Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR][Python] Use ir.Value directly instead of _SubClassValueT #82341

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[MLIR][Python] Use ir.Value directly instead of _SubClassValueT #82341

merged 1 commit into from
Feb 21, 2024
+10 −24

Commits on Feb 20, 2024

  1. [MLIR][Python] Use ir.Value directly instead of _SubClassValueT 

    _SubClassValueT is only useful when it is has >1 usage in a signature.
This was not true for the signatures produced by tblgen.

For example

    def call(result, callee, operands_, *, loc=None, ip=None) -> _SubClassValueT:
      ...

here a type checker does not have enough information to infer a type argument
for _SubClassValueT, and thus effectively treats it as Any.
    @superbobry
    superbobry committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f0ce602 View commit details
    Browse the repository at this point in the history