Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asan] Pre-commit test for asan support of funclet token #82631

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

sylvain-audi
Copy link
Contributor

This is in preparation for PR #82533.

Here we Introduce a test for asan instrumentation where invalid code is output (see bug #64990)
The CHECK lines are generated using update_test_checks.py script. The actual fix PR will udpate this test to highlight the changes in the generated code.

@sylvain-audi
Copy link
Contributor Author

Note that this test now also applies win-eh-prepare pass, on top of asan one.
It was to highlight the outcome of the bug, since WinEHPrepare would invalidate entire BBs due to missing funclet tokens.
Without that extra pass, the diff would only show the added tokens, not highlighting the bug fix for #64990.

Please let me know if you think I should go back to not involving win-eh-prepare.

@sylvain-audi sylvain-audi force-pushed the saudi/asan_funclet_test branch from 5c9cabc to 8f6bd67 Compare March 1, 2024 15:41
This is in preparation for PR llvm#82533 , that will update the test with the correct output.
@sylvain-audi sylvain-audi force-pushed the saudi/asan_funclet_test branch from 8f6bd67 to eac9248 Compare March 1, 2024 18:26
@sylvain-audi sylvain-audi merged commit dd426fa into llvm:main Mar 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants