Skip to content

[InstCombine] Handle vec values when constant fold comparisons with constant values with range info. #84673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[InstCombine] Handle vec values when constant fold comparisons with constant values with range info. #84673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Analysis/InstructionSimplify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3788,10 +3788,10 @@ static Value *simplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
*LHS_Instr->getMetadata(LLVMContext::MD_range));

if (LHS_CR.icmp(Pred, RHS_CR))
return ConstantInt::getTrue(RHS->getContext());
return ConstantInt::getTrue(ITy);

if (LHS_CR.icmp(CmpInst::getInversePredicate(Pred), RHS_CR))
return ConstantInt::getFalse(RHS->getContext());
return ConstantInt::getFalse(ITy);
}
}

Expand Down
36 changes: 36 additions & 0 deletions llvm/test/Transforms/InstCombine/icmp-range.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,42 @@ define i1 @test_two_ranges3(ptr nocapture readonly %arg1, ptr nocapture readonly
ret i1 %rval
}

; Values' ranges overlap each other, so it can not be simplified.
define <2 x i1> @test_two_ranges_vec(ptr nocapture readonly %arg1, ptr nocapture readonly %arg2) {
; CHECK-LABEL: @test_two_ranges_vec(
; CHECK-NEXT: [[VAL1:%.*]] = load <2 x i32>, ptr [[ARG1:%.*]], align 8, !range [[RNG4]]
; CHECK-NEXT: [[VAL2:%.*]] = load <2 x i32>, ptr [[ARG2:%.*]], align 8, !range [[RNG5]]
; CHECK-NEXT: [[RVAL:%.*]] = icmp ult <2 x i32> [[VAL2]], [[VAL1]]
; CHECK-NEXT: ret <2 x i1> [[RVAL]]
;
%val1 = load <2 x i32>, ptr %arg1, !range !5
%val2 = load <2 x i32>, ptr %arg2, !range !6
%rval = icmp ult <2 x i32> %val2, %val1
ret <2 x i1> %rval
}

; Values' ranges do not overlap each other, so it can simplified to false.
define <2 x i1> @test_two_ranges_vec_true(ptr nocapture readonly %arg1, ptr nocapture readonly %arg2) {
; CHECK-LABEL: @test_two_ranges_vec_true(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%val1 = load <2 x i32>, ptr %arg1, !range !0
%val2 = load <2 x i32>, ptr %arg2, !range !6
%rval = icmp ult <2 x i32> %val2, %val1
ret <2 x i1> %rval
}

; Values' ranges do not overlap each other, so it can simplified to false.
define <2 x i1> @test_two_ranges_vec_false(ptr nocapture readonly %arg1, ptr nocapture readonly %arg2) {
; CHECK-LABEL: @test_two_ranges_vec_false(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%val1 = load <2 x i32>, ptr %arg1, !range !0
%val2 = load <2 x i32>, ptr %arg2, !range !6
%rval = icmp ugt <2 x i32> %val2, %val1
ret <2 x i1> %rval
}

define i1 @ugt_zext(i1 %b, i8 %x) {
; CHECK-LABEL: @ugt_zext(
; CHECK-NEXT: [[TMP1:%.*]] = icmp eq i8 [[X:%.*]], 0
Expand Down